Skip to content

Properly handle versification changing when a verse ref has segments defined#300

Open
Enkidu93 wants to merge 6 commits into
mainfrom
handle_versification_mapping_with_segments
Open

Properly handle versification changing when a verse ref has segments defined#300
Enkidu93 wants to merge 6 commits into
mainfrom
handle_versification_mapping_with_segments

Conversation

@Enkidu93
Copy link
Copy Markdown
Collaborator

@Enkidu93 Enkidu93 commented May 19, 2026

Fixes #299


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit May 19, 2026 21:36
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2026

Codecov Report

❌ Patch coverage is 97.91667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.53%. Comparing base (aa71f15) to head (ab9d57e).

Files with missing lines Patch % Lines
machine/scripture/verse_ref.py 93.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   91.51%   91.53%   +0.02%     
==========================================
  Files         355      355              
  Lines       22934    23026      +92     
==========================================
+ Hits        20987    21077      +90     
- Misses       1947     1949       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port 'Support VerseRefs with segments across versifications'

2 participants