Skip to content

Refactor Serval.DataFiles to vertical slices#943

Open
ddaspit wants to merge 1 commit into
mainfrom
data-files-slices
Open

Refactor Serval.DataFiles to vertical slices#943
ddaspit wants to merge 1 commit into
mainfrom
data-files-slices

Conversation

@ddaspit
Copy link
Copy Markdown
Contributor

@ddaspit ddaspit commented May 12, 2026

This change is Reviewable

@ddaspit ddaspit force-pushed the data-files-slices branch 4 times, most recently from b5397ce to 1e1c200 Compare May 13, 2026 13:32
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 13, 2026

Codecov Report

❌ Patch coverage is 86.12040% with 83 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.69%. Comparing base (39e9d69) to head (f34432d).

Files with missing lines Patch % Lines
src/Serval/src/Serval.Client/Client.g.cs 71.00% 35 Missing and 23 partials ⚠️
...val.DataFiles/Features/DataFiles/UpdateDataFile.cs 82.45% 7 Missing and 3 partials ⚠️
...ared/Configuration/IServiceCollectionExtensions.cs 53.84% 6 Missing ⚠️
.../Serval.DataFiles/Features/Corpora/UpdateCorpus.cs 95.00% 1 Missing and 2 partials ⚠️
.../Serval.DataFiles/Features/Corpora/DeleteCorpus.cs 83.33% 1 Missing and 1 partial ⚠️
src/Serval/src/Serval.ApiServer/Startup.cs 0.00% 0 Missing and 1 partial ⚠️
.../src/Serval.DataFiles/Handlers/GetCorpusHandler.cs 96.00% 0 Missing and 1 partial ⚠️
...rc/Serval.DataFiles/Handlers/GetDataFileHandler.cs 85.71% 0 Missing and 1 partial ⚠️
...l/src/Serval.DataFiles/Services/DataFileDeleter.cs 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
- Coverage   66.73%   66.69%   -0.04%     
==========================================
  Files         372      381       +9     
  Lines       21687    21736      +49     
  Branches     2771     2773       +2     
==========================================
+ Hits        14472    14497      +25     
- Misses       6179     6203      +24     
  Partials     1036     1036              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ddaspit ddaspit requested a review from Enkidu93 May 13, 2026 13:43
Copy link
Copy Markdown
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 partially reviewed 43 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ddaspit).


src/Serval/src/Serval.ApiServer/Startup.cs line 157 at r1 (raw file):

        if (Environment.IsDevelopment())
        {
            services

This isn't related, is it? Is this just because we never really followed up on using OpenTelemetry?

Copy link
Copy Markdown
Contributor Author

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddaspit made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93).


src/Serval/src/Serval.ApiServer/Startup.cs line 157 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

This isn't related, is it? Is this just because we never really followed up on using OpenTelemetry?

Yeah, I was sick of seeing all of the noise of the trace messages on the commandline. We have no plans to do anything with tracing, so I just removed it.

@ddaspit ddaspit force-pushed the data-files-slices branch from 1e1c200 to f34432d Compare May 15, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants