Specify sourceRefs and targetRefs in JSON sent to machine.py#946
Specify sourceRefs and targetRefs in JSON sent to machine.py#946pmachapman wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #946 +/- ##
==========================================
- Coverage 66.73% 66.70% -0.03%
==========================================
Files 372 372
Lines 21687 21695 +8
Branches 2771 2773 +2
==========================================
Hits 14472 14472
- Misses 6179 6187 +8
Partials 1036 1036 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enkidu93
left a comment
There was a problem hiding this comment.
I can't believe I missed this 😵. Thank you, Peter! Sorry about all this!
@Enkidu93 reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ddaspit).
|
Do you mean |
Enkidu93
left a comment
There was a problem hiding this comment.
@ddaspit, we were previously testing this code here: https://github.com/sillsdev/serval/blob/fc1bffdfe797abd94f0ffe1df0635e572b58e975/src/Machine/test/Serval.Machine.Shared.Tests/Consumers/TranslationInsertPretranslationsConsumerTests.cs. Is there some equivalent place in the new monolith tests that it should be tested?
@Enkidu93 made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ddaspit and pmachapman).
ddaspit
left a comment
There was a problem hiding this comment.
This code now lives in ServalTranslationPlatformService. We should add a new test fixture for the class that tests the InsertInferenceResultsAsync method.
@ddaspit reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).
Fixes #940.
Requires sillsdev/machine.py#297.
This change is