Replace Hangfire build job runner with a local implementation#947
Replace Hangfire build job runner with a local implementation#947ddaspit wants to merge 4 commits into
Conversation
043389d to
a490550
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #947 +/- ##
==========================================
- Coverage 66.69% 64.69% -2.00%
==========================================
Files 381 378 -3
Lines 21736 21620 -116
Branches 2773 2761 -12
==========================================
- Hits 14497 13988 -509
- Misses 6203 6608 +405
+ Partials 1036 1024 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…eded; fix incorrect runner bug; explicitly set machine.py version in docker-compose.yml
5cd22da to
0c064cc
Compare
|
I ended up only making a few updates:
|
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit partially reviewed 43 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).
src/Machine/src/Serval.Machine.Shared/Models/Build.cs line 13 at r3 (raw file):
public enum BuildJobRunnerType { Hangfire,
I think we can safely remove this type. We will need to make sure that there aren't any currently running builds before we deploy.
ddaspit
left a comment
There was a problem hiding this comment.
I don't think I can approve this PR, since I created it.
@ddaspit reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
This change is