Skip to content

Replace Hangfire build job runner with a local implementation#947

Open
ddaspit wants to merge 4 commits into
mainfrom
remove-hangfire-machine
Open

Replace Hangfire build job runner with a local implementation#947
ddaspit wants to merge 4 commits into
mainfrom
remove-hangfire-machine

Conversation

@ddaspit
Copy link
Copy Markdown
Contributor

@ddaspit ddaspit commented May 15, 2026

This change is Reviewable

@ddaspit ddaspit force-pushed the remove-hangfire-machine branch from 043389d to a490550 Compare May 15, 2026 13:54
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 15, 2026

Codecov Report

❌ Patch coverage is 61.41732% with 147 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.69%. Comparing base (a010758) to head (f2882bf).

Files with missing lines Patch % Lines
...val.Machine.Shared/Services/LocalBuildJobRunner.cs 73.46% 63 Missing and 2 partials ⚠️
...Shared/Services/StatisticalLocalBuildJobFactory.cs 2.70% 36 Missing ⚠️
...Shared/Services/SmtTransferLocalBuildJobFactory.cs 2.77% 35 Missing ⚠️
...Machine.Shared/Services/NmtLocalBuildJobFactory.cs 85.71% 2 Missing and 3 partials ⚠️
...ine/src/Serval.Machine.Shared/Services/BuildJob.cs 66.66% 2 Missing ⚠️
...l.Machine.Shared/Services/ClearMLBuildJobRunner.cs 66.66% 1 Missing ⚠️
...achine.Shared/Services/SmtTransferEngineService.cs 0.00% 1 Missing ⚠️
...achine.Shared/Services/StatisticalEngineService.cs 0.00% 1 Missing ⚠️
...e.Shared/Services/ThotWordAlignmentModelFactory.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #947      +/-   ##
==========================================
- Coverage   66.69%   64.69%   -2.00%     
==========================================
  Files         381      378       -3     
  Lines       21736    21620     -116     
  Branches     2773     2761      -12     
==========================================
- Hits        14497    13988     -509     
- Misses       6203     6608     +405     
+ Partials     1036     1024      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ddaspit and others added 2 commits May 20, 2026 11:46
@Enkidu93 Enkidu93 force-pushed the remove-hangfire-machine branch from 5cd22da to 0c064cc Compare May 20, 2026 15:46
@Enkidu93
Copy link
Copy Markdown
Collaborator

I ended up only making a few updates:

  • The wrong runner was being used for SMT training
  • Fixed a few small bugs in the local SMT training job
  • Removed unused data parameter (this was something in my PR that wasn't in yours - we could also strongly type the build data but since it's ephemeral, I don't know that it matters. Happy to do so if you prefer)
  • Explicitly set the machine.py version in the docker-compose. Is there a reason we haven't done this before? I think it's easy enough to set the version in a branch if you want to test a testing-only version of machine.py. This also makes it easy when pushing to QA because I can just use whatever version of machine.py is in the docker-compose in that commit and feel confident that it is the correct one that is compatible with the code currently on main.

@Enkidu93 Enkidu93 marked this pull request as ready for review May 20, 2026 15:53
@Enkidu93 Enkidu93 requested a review from pmachapman May 20, 2026 15:53
Copy link
Copy Markdown
Contributor Author

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddaspit partially reviewed 43 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).


src/Machine/src/Serval.Machine.Shared/Models/Build.cs line 13 at r3 (raw file):

public enum BuildJobRunnerType
{
    Hangfire,

I think we can safely remove this type. We will need to make sure that there aren't any currently running builds before we deploy.

Copy link
Copy Markdown
Contributor Author

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: I don't think I can approve this PR, since I created it.

@ddaspit reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants