Skip to content

fix(trigger): show selector display names on canvas for trigger file/sheet selectors #4097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
Apr 10, 2026
+13 −2
Merged

fix(trigger): show selector display names on canvas for trigger file/sheet selectors #4097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f38efa2
fix(trigger): show selector display names on canvas for trigger file/…
waleedlatif1 Apr 10, 2026
5d6bc86
fix(trigger): use isNonEmptyValue in canonical member scan to match v…
waleedlatif1 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...m/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/workflow-block.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,6 @@ const SubBlockRow = memo(function SubBlockRow({
workspaceId
)

const credentialId = dependencyValues.credential
const knowledgeBaseId = dependencyValues.knowledgeBaseId

const dropdownLabel = useMemo(() => {
Expand Down Expand Up @@ -576,6 +575,7 @@ const SubBlockRow = memo(function SubBlockRow({
const collectionIdValue = resolveContextValue('collectionId')
const spreadsheetIdValue = resolveContextValue('spreadsheetId')
const fileIdValue = resolveContextValue('fileId')
const credentialId = dependencyValues.credential ?? resolveContextValue('oauthCredential')

const { displayName: selectorDisplayName } = useSelectorDisplayName({
subBlock,
Expand Down
13 changes: 12 additions & 1 deletion apps/sim/lib/workflows/subblocks/visibility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,18 @@ export function resolveDependencyValue(
const mode = resolveCanonicalMode(group, values, overrides)
const canonicalResult =
mode === 'advanced' ? (advancedValue ?? basicValue) : (basicValue ?? advancedValue)
return canonicalResult ?? values[dependencyKey]

if (canonicalResult != null) return canonicalResult

for (const [memberId, memberCanonicalId] of Object.entries(
canonicalIndex.canonicalIdBySubBlockId
)) {
if (memberCanonicalId === canonicalId && isNonEmptyValue(values[memberId])) {
return values[memberId]
}
}

return values[dependencyKey]
}

/**
Expand Down
Loading