Conversation
…closed on new task
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Also resets/collapses the resource panel when no Reviewed by Cursor Bugbot for commit 7952f53. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThis PR fixes two related UI bugs in the Confidence Score: 5/5Safe to merge — both fixes are minimal, targeted, and don't introduce new side effects. The two changes are narrow: omitting a previously-wired callback (fixing an over-eager resource removal) and adding an else-branch to collapse the panel on new-task navigation. Both are guarded by existing state/ref checks that prevent unintended re-expansion. No P0/P1 findings. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[resolvedChatId changes] --> B{resolvedChatId truthy?}
B -->|Yes| C[markRead]
B -->|No - New Task| D[clearWidth + setIsResourceCollapsed true]
E[resources array changes] --> F{resources.length > 0 AND panel collapsed?}
F -->|Yes| G[Expand panel, skip transition animation]
F -->|No| H[No-op]
I[User removes @-context from input] --> J{onContextRemove passed?}
J -->|Previously: Yes| K[removeResource called - BUG FIXED]
J -->|Now: undefined| L[No-op - resource stays in bar]
Reviews (1): Last reviewed commit: "fix(ui): dont delete resource on clearin..." | Re-trigger Greptile |
Summary
handled by completely removing on context remove for resource (deleting resource tab functionality remains unchanged)
Type of Change
Testing
Checklist
Screenshots/Videos