Skip to content

[DH[ Use internal cooldown for soul splitter procs #11451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ToppleTheNun merged 1 commit into from
May 8, 2026
+13 −10
Merged

[DH[ Use internal cooldown for soul splitter procs #11451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions engine/class_modules/sc_demon_hunter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,6 +996,7 @@ class demon_hunter_t : public parse_player_effects_t
cooldown_t* metamorphosis;
cooldown_t* throw_glaive;
cooldown_t* vengeful_retreat;
cooldown_t* soul_splitter_icd;

// Devourer
cooldown_t* consume;
Expand Down Expand Up @@ -11457,15 +11458,16 @@ std::string demon_hunter_t::default_temporary_enchant() const
void demon_hunter_t::create_cooldowns()
{
// General
cooldown.sigil_of_spite = get_cooldown( "sigil_of_spite" );
cooldown.felblade = get_cooldown( "felblade" );
cooldown.immolation_aura = get_cooldown( "immolation_aura" );
cooldown.the_hunt = get_cooldown( "the_hunt" );
cooldown.sigil_of_flame = get_cooldown( "sigil_of_flame" );
cooldown.sigil_of_misery = get_cooldown( "sigil_of_misery" );
cooldown.throw_glaive = get_cooldown( "throw_glaive" );
cooldown.vengeful_retreat = get_cooldown( "vengeful_retreat" );
cooldown.metamorphosis = get_cooldown( "metamorphosis" );
cooldown.sigil_of_spite = get_cooldown( "sigil_of_spite" );
cooldown.felblade = get_cooldown( "felblade" );
cooldown.immolation_aura = get_cooldown( "immolation_aura" );
cooldown.the_hunt = get_cooldown( "the_hunt" );
cooldown.sigil_of_flame = get_cooldown( "sigil_of_flame" );
cooldown.sigil_of_misery = get_cooldown( "sigil_of_misery" );
cooldown.throw_glaive = get_cooldown( "throw_glaive" );
cooldown.vengeful_retreat = get_cooldown( "vengeful_retreat" );
cooldown.metamorphosis = get_cooldown( "metamorphosis" );
cooldown.soul_splitter_icd = get_cooldown( "soul_splitter_icd" );

// Devourer
cooldown.consume = get_cooldown( "consume" );
Expand Down Expand Up @@ -12234,7 +12236,7 @@ void demon_hunter_t::spawn_soul_fragment( proc_t* source_proc, soul_fragment typ
sim->print_log( "{} creates {} {}. active={} total={}", *this, n, get_soul_fragment_str( type ),
get_active_soul_fragments( type ), get_total_soul_fragments( type ) );

if ( talent.demon_hunter.soul_splitter->ok() &&
if ( talent.demon_hunter.soul_splitter->ok() && cooldown.soul_splitter_icd->up() &&
rng().roll( talent.demon_hunter.soul_splitter->effectN( 1 ).percent() ) )
{
soul_fragments.push_back( new soul_fragment_t( this, soul_fragment::LESSER, consume_on_activation ) );
Expand All @@ -12244,6 +12246,7 @@ void demon_hunter_t::spawn_soul_fragment( proc_t* source_proc, soul_fragment typ
sim->print_log( "{} creates an additional {} from Soul Splitter. active={} total={}", *this,
get_soul_fragment_str( type ), get_active_soul_fragments( type ),
get_total_soul_fragments( type ) );
cooldown.soul_splitter_icd->start( talent.demon_hunter.soul_splitter->internal_cooldown() );
}
}

Expand Down
Loading