Conversation
in sioc-bc1b-tr01 specifically because that is being used by the longitudinal feedback but we still require an XCOR/YCOR pair to compute the matrices and for the support scripts to work. We are utilizing the :A<num>USEDBYLOOP pv as a condition on whether or not to actuate a magnet. This is a very specific use case of the feedback.
USEDBYLOOP pv is a binary input record, which means the code can dynamically set this value, but the user cannot get a value down to the code level. We want to statically set a pv and get that value down to the code to use as a condition for actuation. This requires a binary output record.
from the code, it can only be written to from the code. We are using a variable to hold this value instead of the PV
it should be able to write to actuators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented new feature based off of new :ADISABLED PV that allows for the disabling of writing to certain actuator devices. For example, Chris Zimmer wanted a feedback loop (sioc-bc1b-tr01) that only controls YCOR because the XCOR is used in the longitudinal energy control. The problem is that all of the matrix math and support scripts need X/Y measurement device pairs as well as XCOR/YCOR actuator pairs to work. This allows for all of the support scripts to work without actually writing to an actuator. Couldn't use the :AUSEDBYLOOP PV because the device support is not bi-directional. The :AUSEDBYLOOP PV is set dynamically by the code base during the voting scheme in the longitudinal feedback. This is a binary input record, so it reads from the code. To send data to the code, you need a binary output record. The new :ADISABLED PV is used as a conditional in Loop.cc for writing to the actuators. This is an Actuator specific pv whereas the :USEDBYLOOP PV is a Device class attribute (for state, measurement, and actuator devices). The BC1B_settings.sh script is very important to this feedback loop working properly.