Subtree removal and adding Cu Inj and FACET models#30
Open
bhardwaj-gopika wants to merge 4 commits into
Open
Conversation
pluflou
reviewed
May 1, 2026
| """Initialize surrogate model and internal cache copy.""" | ||
| super().__init__() | ||
| tm = self._load_torch_model() | ||
| tm = load_model(use_cpu=True) |
Collaborator
|
Let's await until Ryan finishes the facet implementation, rebase, then I can do a thorough review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the LCLS Cu injector subtree from this repo and switched the Cu injector surrogate to use the installable package instead of loading model assets from local checked-in files.
Added a new FACET-II injector surrogate wrapper that loads the packaged FACET model and exposes beam output through the existing covariance-to-particle wrapper.
Added a FACET staged-model factory scaffold alongside the existing CU staged model, plus a placeholder FACET BMAD entrypoint for the future BMAD implementation.