Make retry implementation compliant with SEP spec#1188
Merged
Conversation
- Add throttling-specific backoff base delay (1000ms) per SEP requirement that throttling errors use x=1 vs x=0.05 for non-throttling errors - Use x-amz-retry-after header (integer ms) instead of standard Retry-After header, which the SEP says MUST be ignored - Add upper bound clamping (5s + t_i) for x-amz-retry-after suggested delay - Fix long-polling: backoff then return error when quota exhausted instead of retrying without cost - Change jitter from nextInt(bound) to nextDouble()*delay for precise SEP formula compliance (t_i = b * min(x * r^i, MAX_BACKOFF) where b in [0,1]) - Refactor CUBIC functions to use shared static methods - Add SEP Appendix A test cases for standard mode and CUBIC calculations
mtdowling
approved these changes
May 19, 2026
| } | ||
| return maxOf(suggested, backoff); | ||
| // Clamp suggested delay: min bound is t_i, max bound is 5s + t_i | ||
| var maxBound = backoff.plus(Duration.ofSeconds(5)); |
Member
There was a problem hiding this comment.
nit - might be nice to make 5 a constant so it's easier to know about in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Changes made to the original implementation of retries to make sure it's compliant with the retries SEP.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.