added command and unit tests

Author: Brian Flores

plugin/commands/user/user.go

@@ -28,6 +28,7 @@ func SetupCobraCommands(sl *metadata.SoftlayerCommand) *cobra.Command {
 	cobraCmd.AddCommand(NewDeviceAccessCommand(sl).Command)
 	cobraCmd.AddCommand(NewVpnSubnetCommand(sl).Command)
 	cobraCmd.AddCommand(NewVpnManualCommand(sl).Command)
+	cobraCmd.AddCommand(NewVpnPasswordCommand(sl).Command)
 	return cobraCmd
 }
 

plugin/commands/user/user_suite_test.go

@@ -32,6 +32,7 @@ var availableCommands = []string{
 	"permissions",
 	"remove-access",
 	"vpn-manual",
+	"vpn-password",
 	"vpn-subnet",
 }
 

plugin/commands/user/vpn_password.go

@@ -0,0 +1,59 @@
+package user
+
+import (
+	"strconv"
+
+	"github.com/spf13/cobra"
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/errors"
+	. "github.ibm.com/SoftLayer/softlayer-cli/plugin/i18n"
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/managers"
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/metadata"
+)
+
+type VpnPasswordCommand struct {
+	*metadata.SoftlayerCommand
+	UserManager managers.UserManager
+	Command     *cobra.Command
+	Password    string
+}
+
+func NewVpnPasswordCommand(sl *metadata.SoftlayerCommand) (cmd *VpnPasswordCommand) {
+	thisCmd := &VpnPasswordCommand{
+		SoftlayerCommand: sl,
+		UserManager:      managers.NewUserManager(sl.Session),
+	}
+
+	cobraCmd := &cobra.Command{
+		Use:   "vpn-password " + T("IDENTIFIER"),
+		Short: T("Set the user VPN password."),
+		Args:  metadata.OneArgs,
+		RunE: func(cmd *cobra.Command, args []string) error {
+			return thisCmd.Run(args)
+		},
+	}
+
+	cobraCmd.Flags().StringVar(&thisCmd.Password, "password", "", T("Your new VPN password [required]"))
+
+	//#nosec G104 -- This is a false positive
+	cobraCmd.MarkFlagRequired("password")
+
+	thisCmd.Command = cobraCmd
+	return thisCmd
+}
+
+func (cmd *VpnPasswordCommand) Run(args []string) error {
+	userID, err := strconv.Atoi(args[0])
+	if err != nil {
+		return errors.NewInvalidSoftlayerIdInputError("User ID")
+	}
+
+	success, err := cmd.UserManager.UpdateVpnPassword(userID, cmd.Password)
+	if err != nil {
+		return errors.NewAPIError(T("Failed to update user vpn password."), err.Error(), 2)
+	}
+	if success {
+		cmd.UI.Ok()
+		cmd.UI.Print(T("Successfully updated user vpn."))
+	}
+	return nil
+}

plugin/commands/user/vpn_password_test.go

@@ -0,0 +1,79 @@
+package user_test
+
+import (
+	"errors"
+
+	"github.com/IBM-Cloud/ibm-cloud-cli-sdk/testhelpers/terminal"
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+	"github.com/softlayer/softlayer-go/session"
+
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/commands/user"
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/metadata"
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/testhelpers"
+)
+
+var _ = Describe("user vpn-password", func() {
+	var (
+		fakeUI          *terminal.FakeUI
+		cliCommand      *user.VpnPasswordCommand
+		fakeSession     *session.Session
+		slCommand       *metadata.SoftlayerCommand
+		fakeUserManager *testhelpers.FakeUserManager
+	)
+	BeforeEach(func() {
+		fakeUI = terminal.NewFakeUI()
+		fakeSession = testhelpers.NewFakeSoftlayerSession([]string{})
+		fakeUserManager = new(testhelpers.FakeUserManager)
+		slCommand = metadata.NewSoftlayerCommand(fakeUI, fakeSession)
+		cliCommand = user.NewVpnPasswordCommand(slCommand)
+		cliCommand.Command.PersistentFlags().Var(cliCommand.OutputFlag, "output", "--output=JSON for json output.")
+		cliCommand.UserManager = fakeUserManager
+	})
+
+	Describe("user vpn-password", func() {
+
+		Context("Return error", func() {
+			It("Set command without Argument", func() {
+				err := testhelpers.RunCobraCommand(cliCommand.Command)
+				Expect(err).To(HaveOccurred())
+				Expect(err.Error()).To(ContainSubstring("Incorrect Usage: This command requires one argument"))
+			})
+
+			It("Set command with an invalid user Id", func() {
+				err := testhelpers.RunCobraCommand(cliCommand.Command, "abcde", "--password=Mypassword1.")
+				Expect(err).To(HaveOccurred())
+				Expect(err.Error()).To(ContainSubstring("Invalid input for 'User ID'. It must be a positive integer."))
+			})
+
+			It("Set without any option", func() {
+				err := testhelpers.RunCobraCommand(cliCommand.Command, "111111")
+				Expect(err).To(HaveOccurred())
+				Expect(err.Error()).To(ContainSubstring(`required flag(s) "password" not set`))
+			})
+		})
+
+		Context("Return error", func() {
+			BeforeEach(func() {
+				fakeUserManager.UpdateVpnPasswordReturns(false, errors.New("Failed to update user vpn password."))
+			})
+			It("Failed edit user", func() {
+				err := testhelpers.RunCobraCommand(cliCommand.Command, "111111", "--password=Mypassword1.")
+				Expect(err).To(HaveOccurred())
+				Expect(err.Error()).To(ContainSubstring("Failed to update user vpn password."))
+			})
+		})
+
+		Context("Return no error", func() {
+			BeforeEach(func() {
+				fakeUserManager.UpdateVpnPasswordReturns(true, nil)
+			})
+			It("enable", func() {
+				err := testhelpers.RunCobraCommand(cliCommand.Command, "111111", "--password=Mypassword1.")
+				Expect(err).NotTo(HaveOccurred())
+				Expect(fakeUI.Outputs()).To(ContainSubstring("OK"))
+				Expect(fakeUI.Outputs()).To(ContainSubstring("Successfully updated user vpn"))
+			})
+		})
+	})
+})

plugin/managers/user.go

@@ -58,6 +58,7 @@ type UserManager interface {
 	UpdateVpnUser(userId int) (bool, error)
 	GetOverrides(userId int) ([]datatypes.Network_Service_Vpn_Overrides, error)
 	DeleteUserVpnOverride(overrideId int) (bool, error)
+	UpdateVpnPassword(userID int, password string) (bool, error)
 }
 
 type userManager struct {
@@ -362,3 +363,10 @@ func (u userManager) DeleteUserVpnOverride(overrideId int) (bool, error) {
 	networkServiceVpnOverridesService := services.GetNetworkServiceVpnOverridesService(u.Session)
 	return networkServiceVpnOverridesService.Id(overrideId).DeleteObject()
 }
+
+// Update a user’s VPN password.
+// int userID: The user customer identifier.
+// string password: New password
+func (u userManager) UpdateVpnPassword(userID int, password string) (bool, error) {
+	return u.UserCustomerService.Id(userID).UpdateVpnPassword(&password)
+}