Skip to content

Commit 4e05f3f

Browse files
refactor: integrated DSPAudioBuffer and DSPAudioArray into codebase (#985)
* refactor: implmented aligned audio array implementation * refactor: renamed includes from AudioArray.h to AudioArray.hpp * refactor: implemented AlignedAudioBuffer * refactor: renamed AudioBuffer.h to AudioBuffer.hpp and updated all includes accordingly * fix: nitpicks * refactor: integrated DSPAudioBuffer and DSPAudioArray into codebase * fix: nits * fix: nits --------- Co-authored-by: maciejmakowski2003 <maciejmakowski2003@users.noreply.github.com>
1 parent 7426b37 commit 4e05f3f

93 files changed

Lines changed: 556 additions & 588 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

packages/audiodocs/docs/guides/create-your-own-effect.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ public:
5252
explicit MyProcessorNode(const std::shared_ptr<BaseAudioContext> &context, );
5353

5454
protected:
55-
std::shared_ptr<AudioBuffer>
56-
processNode(const std::shared_ptr<AudioBuffer> &buffer,
55+
std::shared_ptr<DSPAudioBuffer>
56+
processNode(const std::shared_ptr<DSPAudioBuffer> &buffer,
5757
int framesToProcess) override;
5858

5959
// highlight-start
@@ -80,7 +80,7 @@ namespace audioapi {
8080
isInitialized_.store(true, std::memory_order_release);
8181
}
8282

83-
std::shared_ptr<AudioBuffer> MyProcessorNode::processNode(const std::shared_ptr<AudioBuffer> &buffer,
83+
std::shared_ptr<DSPAudioBuffer> MyProcessorNode::processNode(const std::shared_ptr<DSPAudioBuffer> &buffer,
8484
int framesToProcess) {
8585
// highlight-start
8686
for (int channel = 0; channel < buffer->getNumberOfChannels(); ++channel) {

packages/custom-node-generator/templates/basic/shared/MyProcessorNode.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ MyProcessorNode::MyProcessorNode(
77
isInitialized_.store(true, std::memory_order_release);
88
}
99

10-
std::shared_ptr<AudioBuffer>
11-
MyProcessorNode::processNode(const std::shared_ptr<AudioBuffer> &buffer,
10+
std::shared_ptr<DSPAudioBuffer>
11+
MyProcessorNode::processNode(const std::shared_ptr<DSPAudioBuffer> &buffer,
1212
int framesToProcess) {
1313
// put your processing logic here
1414
}

packages/custom-node-generator/templates/basic/shared/MyProcessorNode.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ class MyProcessorNode : public AudioNode {
1010
explicit MyProcessorNode(const std::shared_ptr<BaseAudioContext> &context, );
1111

1212
protected:
13-
std::shared_ptr<AudioBuffer>
14-
processNode(const std::shared_ptr<AudioBuffer> &buffer,
13+
std::shared_ptr<DSPAudioBuffer>
14+
processNode(const std::shared_ptr<DSPAudioBuffer> &buffer,
1515
int framesToProcess) override;
1616
};
1717
} // namespace audioapi

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
#include <audioapi/core/utils/Locker.h>
1313
#include <audioapi/events/AudioEventHandlerRegistry.h>
1414
#include <audioapi/utils/AudioFileProperties.h>
15-
#include <audioapi/utils/CircularAudioArray.h>
15+
#include <audioapi/utils/CircularArray.hpp>
1616
#include <audioapi/utils/CircularOverflowableAudioArray.h>
1717

1818
#include <memory>

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
namespace audioapi {
1313

14-
class CircularAudioArray;
1514
class AudioFileProperties;
1615
class AndroidRecorderCallback;
1716
class AndroidFileWriterBackend;

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AudioPlayer.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
namespace audioapi {
1313

1414
AudioPlayer::AudioPlayer(
15-
const std::function<void(std::shared_ptr<AudioBuffer>, int)> &renderAudio,
15+
const std::function<void(std::shared_ptr<DSPAudioBuffer>, int)> &renderAudio,
1616
float sampleRate,
1717
int channelCount)
1818
: renderAudio_(renderAudio),
@@ -42,7 +42,7 @@ bool AudioPlayer::openAudioStream() {
4242
return false;
4343
}
4444

45-
buffer_ = std::make_shared<AudioBuffer>(RENDER_QUANTUM_SIZE, channelCount_, sampleRate_);
45+
buffer_ = std::make_shared<DSPAudioBuffer>(RENDER_QUANTUM_SIZE, channelCount_, sampleRate_);
4646
return true;
4747
}
4848

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AudioPlayer.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class AudioContext;
1717
class AudioPlayer : public AudioStreamDataCallback, AudioStreamErrorCallback {
1818
public:
1919
AudioPlayer(
20-
const std::function<void(std::shared_ptr<AudioBuffer>, int)> &renderAudio,
20+
const std::function<void(std::shared_ptr<DSPAudioBuffer>, int)> &renderAudio,
2121
float sampleRate,
2222
int channelCount);
2323

@@ -40,9 +40,9 @@ class AudioPlayer : public AudioStreamDataCallback, AudioStreamErrorCallback {
4040
void onErrorAfterClose(AudioStream * /* audioStream */, Result /* error */) override;
4141

4242
private:
43-
std::function<void(std::shared_ptr<AudioBuffer>, int)> renderAudio_;
43+
std::function<void(std::shared_ptr<DSPAudioBuffer>, int)> renderAudio_;
4444
std::shared_ptr<AudioStream> mStream_;
45-
std::shared_ptr<AudioBuffer> buffer_;
45+
std::shared_ptr<DSPAudioBuffer> buffer_;
4646
bool isInitialized_ = false;
4747
float sampleRate_;
4848
int channelCount_;

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/utils/AndroidRecorderCallback.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
#include <audioapi/events/AudioEventHandlerRegistry.h>
55
#include <audioapi/libs/miniaudio/miniaudio.h>
66
#include <audioapi/utils/AudioArray.hpp>
7-
8-
#include <audioapi/utils/CircularAudioArray.h>
7+
#include <audioapi/utils/CircularArray.hpp>
98

109
#include <algorithm>
1110
#include <memory>

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/utils/AndroidRecorderCallback.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
namespace audioapi {
1212

13-
class CircularAudioArray;
1413
class AudioEventHandlerRegistry;
1514

1615
struct CallbackData {

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/effects/ConvolverNodeHostObject.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,17 +80,17 @@ void ConvolverNodeHostObject::setBuffer(const std::shared_ptr<AudioBuffer> &buff
8080
convolvers.back().init(RENDER_QUANTUM_SIZE, channelData, copiedBuffer->getSize());
8181
}
8282

83-
auto internalBuffer = std::make_shared<AudioBuffer>(
83+
auto internalBuffer = std::make_shared<DSPAudioBuffer>(
8484
RENDER_QUANTUM_SIZE * 2, convolverNode->getChannelCount(), copiedBuffer->getSampleRate());
85-
auto intermediateBuffer = std::make_shared<AudioBuffer>(
85+
auto intermediateBuffer = std::make_shared<DSPAudioBuffer>(
8686
RENDER_QUANTUM_SIZE, convolvers.size(), copiedBuffer->getSampleRate());
8787

8888
struct SetupData {
8989
std::shared_ptr<AudioBuffer> buffer;
9090
std::vector<Convolver> convolvers;
9191
std::shared_ptr<ThreadPool> threadPool;
92-
std::shared_ptr<AudioBuffer> internalBuffer;
93-
std::shared_ptr<AudioBuffer> intermediateBuffer;
92+
std::shared_ptr<DSPAudioBuffer> internalBuffer;
93+
std::shared_ptr<DSPAudioBuffer> intermediateBuffer;
9494
float scaleFactor;
9595
};
9696

0 commit comments

Comments
 (0)