Change macOS shortcuts that use Function keys to use Command#1714
Draft
iffy wants to merge 1 commit intosolvespace:masterfrom
Draft
Change macOS shortcuts that use Function keys to use Command#1714iffy wants to merge 1 commit intosolvespace:masterfrom
iffy wants to merge 1 commit intosolvespace:masterfrom
Conversation
Member
|
Not in its present form. That's really ugly in the middle of that section of code, and it's only those 3 keys? Would it be better to modify the macOS-specific layer to pass the command key in place of the function key? That way ALL the shortcuts would use the other key? Could you possibly map both of them to function key so either could be used? |
Member
|
In its present form - a definite no from me as well. I totally agree with what @phkahler wrote above. This should only modify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the standard macOS wireless keyboard, the function keys are a little annoying to press (needs 2 hands). This changes shortcuts keys to use Command instead of Function. I'm not offended if you reject this.