Integrate HW-MGMT Version 7.0060.1002#566
Conversation
## Patch List * 0054-1-platform-mellanox-Downstream-Add-support-for-new-Nvi.patch : * 0055-1-platform-mellanox-mlx-platform-Add-support-DGX-flavo.patch : * 0058-PCI-DOE-Poll-DOE-Busy-bit-for-up-to-1-second-in-pci.patch : torvalds/linux@86efc62 * 0059-hwmon-pmbus-xdpe1a2g7b-Add-support-for-XDPE1A2G7B-5B.patch : Signed-off-by: sw-r2d2-bot <sw-r2d2-bot@nvidia.com>
paulmenzel
left a comment
paulmenzel
left a comment
There was a problem hiding this comment.
A bot should not sign off commits.
| CONFIG_MLXSW_I2C=m | ||
| CONFIG_MLXSW_MINIMAL=m | ||
| CONFIG_MLXSW_CORE_THERMAL=n | ||
| CONFIG_NVSW_HOST_L1=m |
There was a problem hiding this comment.
Please make changes in this file a separate commit with an elaborate commit message.
There was a problem hiding this comment.
same reasoning as below about the commit message. Is this a nit or any specific reason behind separate commit?
There was a problem hiding this comment.
It’s not mentioned in the commit message as far as I can see, and looks like a separate change, that should be a separate commit (or even merge/pull request) with an explanation.
| 0058-PCI-DOE-Poll-DOE-Busy-bit-for-up-to-1-second-in-pci.patch | ||
| 0059-hwmon-pmbus-xdpe1a2g7b-Add-support-for-XDPE1A2G7B-5B.patch | ||
| 8000-mlxsw-Use-weak-reverse-dependencies-for-firmware-fla.patch | ||
| 8001-platform-mlx-platform-Downstream-Add-SPI-path-for-ra.patch |
There was a problem hiding this comment.
The commit message should mention the renaming and the reason.
There was a problem hiding this comment.
Hi @paulmenzel These changes are made when we integrate a new lower-layer component. The reason for changes can be understood in more detail from https://github.com/Mellanox/hw-mgmt repo from the specific version of the component - in this case 7.0060.1002 (mentioned in the title). As there are several changes for each component upgrade and each change has a reason from the hw-mgmt repo. As we do this upgrade often and these integration commits could get very verbose. So I believe we should keep this to minimal and abstract away the details of lower layer components - and just point to the hw-mgmt repo for all information. Let us know if we can't resolve this
There was a problem hiding this comment.
@tirupatihemanth, thank you for repsonding. Reviewers time is scarce, and, therefore, review should be made as simple as possible. I went to https://github.com/Mellanox/hw-mgmt, and can’t find that tag. Also not on the first release page. One improvement would be to mention the previous version in the commit message, and also add URLs for the added release.
Your commit message already lists patches, and has some superfluous colons, which should be removed. I think that list could be expanded a little to help the reviewer wit renames and so on.
5 participants
Why I did it
Integrate HW-MGMT 7.0060.1002 Changes
Patch List
Signed-off-by: sw-r2d2-bot sw-r2d2-bot@nvidia.com
How I did it
Run make integrate-mlnx-hw-mgmt