fix: more code cleanup

Author: olafurpg

src/file-system/FileTree.test.ts

@@ -47,14 +47,6 @@ function checkChildren(directory: string, expected: string[]) {
     })
 }
 describe('FileTree', () => {
-    it('binarySearchStart', () => {
-        const end = tree.binarySearchDirectoryStart('src/browse/')
-        console.log(`end=${end} file=${tree.files[end]}`)
-    })
-    it('binarySearchEnd', () => {
-        const end = tree.binarySearchDirectoryEnd('src/browse/', 0)
-        console.log(`end=${end} file=${tree.files[end]}`)
-    })
     checkChildren('src', ['src/browse/', 'src/git/', 'src/config.ts', 'src/extension.ts', 'src/log.ts'])
     checkChildren('', [
         '.github/workflows/',

src/file-system/FileTree.ts

@@ -66,7 +66,7 @@ export class FileTree {
         return [...directDirectories, ...directFiles]
     }
 
-    public binarySearchDirectoryStart(directory: string): number {
+    private binarySearchDirectoryStart(directory: string): number {
         if (directory === '') {
             return 0
         }
@@ -76,7 +76,7 @@ export class FileTree {
         )
     }
 
-    public binarySearchDirectoryEnd(directory: string, low: number): number {
+    private binarySearchDirectoryEnd(directory: string, low: number): number {
         while (low < this.files.length && this.files[low].localeCompare(directory) <= 0) {
             low++
         }
@@ -86,7 +86,7 @@ export class FileTree {
         )
     }
 
-    public binarySearch({ low, high }: SearchRange, isGreater: (midpoint: number) => boolean): number {
+    private binarySearch({ low, high }: SearchRange, isGreater: (midpoint: number) => boolean): number {
         while (low < high) {
             const midpoint = Math.floor(low + (high - low) / 2)
             if (isGreater(midpoint)) {

src/file-system/SourcegraphTreeDataProvider.ts

@@ -43,6 +43,17 @@ export class SourcegraphTreeDataProvider implements vscode.TreeDataProvider<stri
     }
 
     public async getParent(uriString?: string): Promise<string | undefined> {
+        // Implementation note: this method is not implemented as
+        // `SourcegraphUri.parse(uri).parentUri()` because that would return
+        // URIs to directories that don't exist because they have no siblings
+        // and are therefore automatically merged with their parent. For example,
+        // imagine the following folder structure:
+        //   .gitignore
+        //   .github/workflows/ci.yml
+        //   src/command.ts
+        //   src/browse.ts
+        // The parent of `.github/workflows/ci.yml` is `.github/` because the `workflows/`
+        // directory has no sibling.
         if (!uriString) {
             return undefined
         }