workflow for speechmatics-dotnet#12
Merged
Merged
Conversation
JamesG-Speechmatics
force-pushed
the
add-workflows-2
branch
2 times, most recently
from
13fda81 to
50ece14
Compare
JamesG-Speechmatics
force-pushed
the
add-workflows-2
branch
from
eb77f43 to
ddc12fe
Compare
JamesG-Speechmatics
force-pushed
the
add-workflows-2
branch
from
67e5665 to
4d0cce0
Compare
HennerM
approved these changes
May 16, 2025
Contributor
HennerM
left a comment
HennerM
left a comment
There was a problem hiding this comment.
this is very cool. If it works, ship it!
giorgosHadji
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a github workflow for the speechmatics-dotnet client.
v\d+.\d+.\d+orv\d+.\d+.\d+-NNNNit will publish tonuget.org.v\d+.\d+.\d+-test*it will publish to the testing nuget repository, this is intended for testing the workflow itself.The build is done with .NET Core 8.0 (on Ubuntu) and as such introduces new linting rules in the compiler, mostly around nullability, these have been fixed so that there are currently no linter warnings or complaints.
*there needs to be a follow up MR to have the tests use the Speechmatics realtime SaaS. I don't intend to tag the repo until that's done. In particular there needs to be testing on both Windows and Linux platforms. It may be necessary to build additional DLLs for 'full fat' .NET on Windows to ensure the package works in more situations.