Merge pull request #145 from splitio/update_version_overwriting

Update how SDK version is overwritten

Author: EmilianoSanchez

src/SplitFactory.tsx

@@ -2,7 +2,7 @@ import React from 'react';
 
 import { SplitComponent } from './SplitClient';
 import { ISplitFactoryProps } from './types';
-import { VERSION, WARN_SF_CONFIG_AND_FACTORY, ERROR_SF_NO_CONFIG_AND_FACTORY } from './constants';
+import { WARN_SF_CONFIG_AND_FACTORY, ERROR_SF_NO_CONFIG_AND_FACTORY } from './constants';
 import { getSplitFactory, destroySplitFactory, IFactoryWithClients } from './utils';
 
 /**
@@ -46,8 +46,6 @@ class SplitFactory extends React.Component<ISplitFactoryProps, { factory: SplitI
       factory = propFactory;
     } else {
       if (config) {
-        // Don't try this at home. Used to overwrite the settings version when we create our own factory.
-        (config as any).version = VERSION;
         // We use an idempotent variant of the Split factory builder (i.e., given the same config, it returns the same already
         // created instance), since React component constructors is part of render-phase and can be invoked multiple times.
         factory = getSplitFactory(config);

src/__tests__/testUtils/mockSplitSdk.ts

@@ -108,7 +108,7 @@ function mockClient(_key: SplitIO.SplitKey, _trafficType?: string) {
 
 export function mockSdk() {
 
-  return jest.fn((config: SplitIO.IBrowserSettings) => {
+  return jest.fn((config: SplitIO.IBrowserSettings, __updateModules) => {
 
     // Manager
     const names: jest.Mock = jest.fn().mockReturnValue([]);
@@ -134,6 +134,8 @@ export function mockSdk() {
       }, config),
     };
 
+    if (__updateModules) __updateModules(factory);
+
     return factory;
   });
 

src/utils.ts

@@ -1,5 +1,6 @@
 import React from 'react';
 import { SplitFactory as SplitSdk } from '@splitsoftware/splitio/client';
+import { VERSION } from './constants';
 
 // Utils used to access singleton instances of Split factories and clients, and to gracefully shutdown all clients together.
 
@@ -31,7 +32,10 @@ export const __factories: Map<SplitIO.IBrowserSettings, IFactoryWithClients> = n
 export function getSplitFactory(config: SplitIO.IBrowserSettings): IFactoryWithClients {
   if (!__factories.has(config)) {
     // SplitSDK is not an idempotent operation
-    const newFactory = SplitSdk(config) as IFactoryWithClients;
+    // @ts-expect-error. 2nd param is not part of type definitions. Used to overwrite the SDK version
+    const newFactory = SplitSdk(config, (modules) => {
+      modules.settings.version = VERSION;
+    }) as IFactoryWithClients;
     newFactory.sharedClientInstances = new Set();
     newFactory.config = config;
     __factories.set(config, newFactory);