Skip to content

PR: Improve LSP support for MarkupString[] for hover requests#10403

Merged
ccordoba12 merged 1 commit intospyder-ide:masterfrom
andfoy:markup_string_hover
Oct 15, 2019
Merged

PR: Improve LSP support for MarkupString[] for hover requests#10403
ccordoba12 merged 1 commit intospyder-ide:masterfrom
andfoy:markup_string_hover

Conversation

@andfoy
Copy link
Copy Markdown
Member

@andfoy andfoy commented Oct 14, 2019

Description of Changes

This PR prevents palantir/python-language-server#623 to break compatibility with Spyder

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@andfoy

@andfoy andfoy added this to the v4.0rc milestone Oct 14, 2019
@andfoy andfoy self-assigned this Oct 14, 2019
Copy link
Copy Markdown
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andfoy! I verified this fix allows us to use the latest PyLS version (0.29.1).

@ccordoba12 ccordoba12 merged commit 49737e2 into spyder-ide:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants