Skip to content

fix: mismatch between BLAS band storage and to-compact #11063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DivitJain26 wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

fix: mismatch between BLAS band storage and to-compact #11063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1ec0528
fix: bounds and indexing for column wise packing updated
DivitJain26 Mar 20, 2026
0927be3
fix: main.js updated
DivitJain26 Mar 20, 2026
dc5ea75
test: test results updated
DivitJain26 Mar 20, 2026
bf311fa
fix: main.js updated
DivitJain26 Mar 20, 2026
5c7af2d
test: test results updated
DivitJain26 Mar 20, 2026
2ecf953
docs: examples updated
DivitJain26 Mar 20, 2026
c962732
docs: examples in types updated
DivitJain26 Mar 20, 2026
66a3504
docs: readme updated
DivitJain26 Mar 20, 2026
e54838c
Merge remote-tracking branch 'upstream/develop' into fix/band-storage…
stdlib-bot Mar 21, 2026
44434a3
Merge branch 'develop' into fix/band-storage-mismatch
DivitJain26 Apr 9, 2026
2b7eb0c
docs: roll back to collection generic type
DivitJain26 Apr 11, 2026
40acc7e
Merge branch 'develop' into fix/band-storage-mismatch
DivitJain26 Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/node_modules/@stdlib/array/base/banded/to-compact/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,11 @@ AC = toCompact( A, 1, 2, false );
AC = toCompact( A, 2, 2, true );
/* e.g., returns =>
[
[ 0, 0, 1, -2, -3 ],
[ 0, 2, 4, -5, -6 ],
[ 3, 5, 7, -8, -9 ],
[ 6, 8, 10, -11, 0 ],
[ 9, 11, 12, 0, 0 ]
[ 0, 0, 1, 2, 3 ],
[ 0, -2, 4, 5, 6 ],
[ -3, -5, 7, 8, 9 ],
[ -6, -8, 10, 11, 0 ],
[ -9, -11, 12, 0, 0 ]
]
*/
```
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/array/base/banded/to-compact/docs/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ type Array2D<T> = Array<Collection<T>>;
* ];
*
* var out = toCompact( M, 1, 1, true );
* // returns [ [ 0, 11, 3 ], [ 2, 12, 5 ], [ 4, 13, 0 ] ]
* // returns [ [ 0, 11, 2 ], [ 3, 12, 4 ], [ 5, 13, 0 ] ]
*/
declare function toCompact<T = unknown>( arr: Array2D<T>, ku: number, kl: number, colexicographic: boolean ): Array2D<T>;

Expand Down
10 changes: 5 additions & 5 deletions lib/node_modules/@stdlib/array/base/banded/to-compact/examples/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@ AC = toCompact( A, 2, 2, true );
console.log( AC );
/* e.g., =>
[
[ 0, 0, 1, -2, -3 ],
[ 0, 2, 4, -5, -6 ],
[ 3, 5, 7, -8, -9 ],
[ 6, 8, 10, -11, 0 ],
[ 9, 11, 12, 0, 0 ]
[ 0, 0, 1, 2, 3 ],
[ 0, -2, 4, 5, 6 ],
[ -3, -5, 7, 8, 9 ],
[ -6, -8, 10, 11, 0 ],
[ -9, -11, 12, 0, 0 ]
]
*/
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/array/base/banded/to-compact/lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
* ];
*
* var out = toCompact( M, 1, 1, true );
* // returns [ [ 0, 11, 3 ], [ 2, 12, 5 ], [ 4, 13, 0 ] ]
* // returns [ [ 0, 11, 2 ], [ 3, 12, 4 ], [ 5, 13, 0 ] ]
*/

// MODULES //
Expand Down
14 changes: 6 additions & 8 deletions lib/node_modules/@stdlib/array/base/banded/to-compact/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,10 @@ var zeros2d = require( '@stdlib/array/base/zeros2d' );
* ];
*
* var out = toCompact( M, 1, 1, true );
* // returns [ [ 0, 11, 3 ], [ 2, 12, 5 ], [ 4, 13, 0 ] ]
* // returns [ [ 0, 11, 2 ], [ 3, 12, 4 ], [ 5, 13, 0 ] ]
*/
function toCompact( arr, ku, kl, colexicographic ) {
var out;
var to;
var M;
var N;
var i;
Expand All @@ -70,12 +69,11 @@ function toCompact( arr, ku, kl, colexicographic ) {

// Check whether to store diagonals along the columns...
if ( colexicographic ) {
out = zeros2d( [ N, ku+kl+1 ] );
for ( j = 0; j < N; j++ ) {
to = out[ j ];
k = ku - j;
for ( i = max( 0, j-ku ); i < min( M, j+kl+1 ); i++ ) {
to[ k+i ] = arr[ i ][ j ];
out = zeros2d( [ M, ku+kl+1 ] );
for ( j = 0; j < M; j++ ) {
k = kl - j;
for ( i = max( 0, j-kl ); i < min( N, j+ku+1 ); i++ ) {
out[ j ][ i+k ] = arr[ j ][ i ];
}
}
return out;
Expand Down
30 changes: 15 additions & 15 deletions lib/node_modules/@stdlib/array/base/banded/to-compact/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,11 @@ tape( 'the function converts a banded nested array to compact banded storage ( c
];

expected = [
[ 0, 0, 1, -2, -3 ],
[ 0, 2, 4, -5, -6 ],
[ 3, 5, 7, -8, -9 ],
[ 6, 8, 10, -11, 0 ],
[ 9, 11, 12, 0, 0 ]
[ 0, 0, 1, 2, 3 ],
[ 0, -2, 4, 5, 6 ],
[ -3, -5, 7, 8, 9 ],
[ -6, -8, 10, 11, 0 ],
[ -9, -11, 12, 0, 0 ]
];
actual = toCompact( arr, 2, 2, true );
t.deepEqual( actual, expected, 'returns expected value' );
Expand All @@ -114,21 +114,21 @@ tape( 'the function converts a banded nested array to compact banded storage ( c
t.deepEqual( actual, expected, 'returns expected value' );

expected = [
[ 0, 1 ],
[ 2, 4 ],
[ 5, 7 ],
[ 8, 10 ],
[ 11, 12 ]
[ 1, 2 ],
[ 4, 5 ],
[ 7, 8 ],
[ 10, 11 ],
[ 12, 0 ]
];
actual = toCompact( arr, 1, 0, true );
t.deepEqual( actual, expected, 'returns expected value' );

expected = [
[ 1, -2, -3 ],
[ 4, -5, -6 ],
[ 7, -8, -9 ],
[ 10, -11, 0 ],
[ 12, 0, 0 ]
[ 0, 0, 1 ],
[ 0, -2, 4 ],
[ -3, -5, 7 ],
[ -6, -8, 10 ],
[ -9, -11, 12 ]
];
actual = toCompact( arr, 0, 2, true );
t.deepEqual( actual, expected, 'returns expected value' );
Expand Down