style: align module import order in ndarray/to-rot180#11861
Closed
Planeshifter wants to merge 1 commit intodevelopfrom
Closed
style: align module import order in ndarray/to-rot180#11861Planeshifter wants to merge 1 commit intodevelopfrom
ndarray/to-rot180#11861Planeshifter wants to merge 1 commit intodevelopfrom
Conversation
…packages Move `@stdlib/string/format` after the `@stdlib/ndarray/base/*` import to match the ordering used in every sibling `ndarray/to-*` package, including the structurally identical `to-rot90`.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for commits merged to
developbetweenb48118129(2026-04-29 15:08 PDT) and44794544d(2026-04-29 23:14 PDT).Description
This pull request applies follow-up fixes from an automated review of the last 24 hours of merges to
develop. Only high-signal, independently verifiable issues were retained.Fixes by package
ndarray/to-rot180— Fix import order inlib/node_modules/@stdlib/ndarray/to-rot180/lib/main.js(introduced ine3a873f):var format = require( '@stdlib/string/format' )precedesvar base = require( '@stdlib/ndarray/base/to-rot180' ), inverting the convention established by every siblingndarray/to-*package (e.g.,to-rot90) where@stdlib/ndarray/base/*imports always come before@stdlib/string/format. Swap the two declarations to restore consistency.Related Issues
None.
Questions
No.
Other
Validation audit
Reviewers checked:
docs/style-guides/) across all touched filesb48118129^..44794544d)modeformula vs. JS+C, ndarray rotation index/stride math, gswap argument parity)Deliberately excluded:
Commit window covered (oldest → newest):
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was generated by Claude Code as part of an automated 24-hour commit review. Findings were filtered to retain only objectively verifiable, high-signal issues; the fix was reviewed against sibling packages before commit. A human maintainer is expected to audit before promoting from draft.
Generated by Claude Code