Skip to content

style: align module import order in ndarray/to-rot180#11861

Closed
Planeshifter wants to merge 1 commit intodevelopfrom
philipp/fix-commit-review-2026-04-30
Closed

style: align module import order in ndarray/to-rot180#11861
Planeshifter wants to merge 1 commit intodevelopfrom
philipp/fix-commit-review-2026-04-30

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Follow-up fixes for commits merged to develop between b48118129 (2026-04-29 15:08 PDT) and 44794544d (2026-04-29 23:14 PDT).

Description

This pull request applies follow-up fixes from an automated review of the last 24 hours of merges to develop. Only high-signal, independently verifiable issues were retained.

Fixes by package

  • ndarray/to-rot180 — Fix import order in lib/node_modules/@stdlib/ndarray/to-rot180/lib/main.js (introduced in e3a873f): var format = require( '@stdlib/string/format' ) precedes var base = require( '@stdlib/ndarray/base/to-rot180' ), inverting the convention established by every sibling ndarray/to-* package (e.g., to-rot90) where @stdlib/ndarray/base/* imports always come before @stdlib/string/format. Swap the two declarations to restore consistency.

Related Issues

None.

Questions

No.

Other

Validation audit

Reviewers checked:

  • stdlib code style compliance (docs/style-guides/) across all touched files
  • bug scan over the union diff (b48118129^..44794544d)
  • correctness scan over introduced logic (Wald mode formula vs. JS+C, ndarray rotation index/stride math, gswap argument parity)

Deliberately excluded:

  • subjective rewording or "improvement" suggestions
  • anything requiring context outside the diff window to validate
  • findings reported by a single reviewer that could not be re-verified from the diff

Commit window covered (oldest → newest):

b48118129 docs: add hpsf conference image link
8dda5d2a2 feat: add `blas/base/ndarray/gswap`
a2c531cdc chore: align outliers in `_tools/lint` with namespace majority patterns
4cd8e438c test: migrate `math/base/special/cbrt` to ULP-based testing
6cda0c6d9 feat: add `ndarray/to-rotl90`
e3a873f24 feat: add `ndarray/to-rot180`
6b16c0bec docs: update related packages sections
e34b36cde docs: update namespace table of contents
7e5f19e57 feat: update `blas/base/ndarray` TypeScript declarations
44794544d feat: add `stats/base/dists/wald/mode`

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was generated by Claude Code as part of an automated 24-hour commit review. Findings were filtered to retain only objectively verifiable, high-signal issues; the fix was reviewed against sibling packages before commit. A human maintainer is expected to audit before promoting from draft.



Generated by Claude Code

…packages

Move `@stdlib/string/format` after the `@stdlib/ndarray/base/*` import to
match the ordering used in every sibling `ndarray/to-*` package, including
the structurally identical `to-rot90`.
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
ndarray/to-rot180 $\color{green}129/129$
$\color{green}+100.00%$
$\color{green}11/11$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}129/129$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants