fix: correct C delegation and benchmark inputs in stats/strided/dpcorr#11890
Merged
fix: correct C delegation and benchmark inputs in stats/strided/dpcorr#11890
stats/strided/dpcorr#11890Conversation
* In `src/main.c`, wrap the delegated `stdlib_strided_dpcorrwd_ndarray` call with `API_SUFFIX(...)` so the symbol resolves correctly when the 64-bit indexing ABI is selected (matches the sibling pattern in `stats/strided/dvariance/src/main.c`). * In `benchmark/c/benchmark.length.c`, pass `y` (not `x` twice) as the second strided array in `benchmark2`, otherwise the benchmark correlates `x` with itself and the allocated `y` is unused. https://claude.ai/code/session_012VgKGaXwsACnoLu7UenrRc
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for commits merged to
developbetween 2026-05-01 17:21 EDT (755a2ee2) and 2026-05-02 14:53 +0530 (6b8823ef).Description
This pull request fixes two bugs introduced in the new
stats/strided/dpcorrpackage (6b8823ef):stats/strided/dpcorrAPI_SUFFIX(...)wrapper aroundstdlib_strided_dpcorrwd_ndarraycall atlib/node_modules/@stdlib/stats/strided/dpcorr/src/main.c:53, introduced in6b8823ef, causing resolution to a non-existent symbol when built against the 64-bit ABI.benchmark2introduced in6b8823ef, wherestdlib_strided_dpcorr_ndarraywas called withxpassed for both array arguments instead ofxandy, causing the benchmark to always compute the autocorrelation ofxand leaving the allocatedyarray unused (lib/node_modules/@stdlib/stats/strided/dpcorr/benchmark/c/benchmark.length.c, line 155).Related Issues
None.
Questions
No.
Other
Validation
The 19 commits in the window were audited by four review agents (two for stdlib code-style compliance, two for bugs). Both findings above were independently re-verified by reading the diff and comparing against sibling packages (
stats/strided/dpcorrwd,stats/strided/dvariance).Deliberately excluded from this PR:
repl.txtvsREADME.mddiscrepancy (N <= 0vsN <= 1) instats/strided/dpcorr— inherited verbatim from thestats/strided/dpcorrwdreference; out of scope for this window.x-passed-twice pattern instats/strided/dpcorrwd/benchmark/c/benchmark.length.c— outside the 24-hour diff window.donecallback in_tools/github/star-repo/factory.js(c7a6b5c8) — closure refs verified intact; no action needed.@throwsordering,package.jsonkeyword alignment, and the EditorConfig EOL fix — mechanical, no defects observed.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored primarily by Claude Code: a summary agent digested the last 24 hours of
developcommits, four parallel review agents (two style, two bug-hunt) identified candidate issues, and the surviving high-signal findings were re-verified manually before applying the fixes. Each fix was confirmed against sibling-package patterns (stats/strided/dpcorrwd,stats/strided/dvariance) prior to commit.@stdlib-js/reviewers
Generated by Claude Code