install/uninstall process improvements#35
Open
sylver wants to merge 1 commit intostevegrunwell:developfrom
Open
install/uninstall process improvements#35sylver wants to merge 1 commit intostevegrunwell:developfrom
sylver wants to merge 1 commit intostevegrunwell:developfrom
Conversation
sylver
force-pushed
the
feature-makefile
branch
4 times, most recently
from
d3495fc to
528cdff
Compare
stevegrunwell
requested changes
Feb 2, 2019
Owner
stevegrunwell
left a comment
stevegrunwell
left a comment
There was a problem hiding this comment.
I had never considered the Makefile route, but for a system-level utility that makes a lot of sense!
I've left a couple notes, but overall this is looking great from a code perspective!
sylver
force-pushed
the
feature-makefile
branch
from
528cdff to
29d324a
Compare
Author
|
@stevegrunwell Thanks for your interest in my PR. I just have one issue : I'm unable to figure out how to pass your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have improved the install process and added an uninstall script, all of these managed by a Makefile.
I have also added a TODO for what I was thinking could be some checks/improvements if I or anyone has the time to work on it.
Hope it will helps, cheers.