Merged
Conversation
Introduce PlannedAddressKind so materialized user-memory reads expose a small address primitive instead of the full VariableLocation enum. The kind records constant, register-offset, frame-base-relative, and computed addresses while AddressOrigin continues to carry rebasing semantics. Lower planned addresses in the compiler by matching PlannedAddressKind directly, then route read-plan value and lvalue address lowering through plan-aware helpers. Address-only lowering derives the planned address without requiring DWARF type metadata. Remove the legacy VariableLocation lowering helpers from compiler tests so this boundary is exercised through read plans instead of compatibility APIs. This keeps complex DWARF expressions behind the computed address escape hatch without letting eBPF lowering inspect source-level VariableLocation shapes. Refs #148.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce PlannedAddressKind so materialized user-memory reads expose a small address primitive instead of the full VariableLocation enum. The kind records constant, register-offset, frame-base-relative, and computed addresses while AddressOrigin continues to carry rebasing semantics.
Lower planned addresses in the compiler by matching PlannedAddressKind directly, then route read-plan value and lvalue address lowering through plan-aware helpers. Address-only lowering derives the planned address without requiring DWARF type metadata.
Remove the legacy VariableLocation lowering helpers from compiler tests so this boundary is exercised through read plans instead of compatibility APIs.
This keeps complex DWARF expressions behind the computed address escape hatch without letting eBPF lowering inspect source-level VariableLocation shapes.
Refs #148.