Gui: redesign Macros dialog layout for clarity#8
Open
dragonfruit-blue wants to merge 1 commit intoswe-productivity:mainfrom
Open
Gui: redesign Macros dialog layout for clarity#8dragonfruit-blue wants to merge 1 commit intoswe-productivity:mainfrom
dragonfruit-blue wants to merge 1 commit intoswe-productivity:mainfrom
Conversation
Reorganize the Macros dialog (formerly "Execute Macro") to more effectively guide users through the available actions: - Rename window title from "Execute Macro" to "Macros" - Remove confusing "Macro Name" group box wrapper - Move search fields (Find file, Find in files) to a clean top row - Place "Selected:" label inline below the macro list - Reorder button column: Execute (primary) → Create/Edit/Rename/ Duplicate/Delete (file management) → Toolbar/Download (secondary) → Close (bottom), with visible separator lines between groups - Fix tab bar clipping by enforcing min-width on each tab Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Thanks for the PR, @dragonfruit-blue -- could you please include before-and-after images in the PR writeup? |
anomolous-lemur
suggested changes
Apr 4, 2026
| <property name="sizeType"> | ||
| <enum>QSizePolicy::Expanding</enum> | ||
| <property name="styleSheet"> | ||
| <string>QLabel { background-color: #aaaaaa; }</string> |
There was a problem hiding this comment.
Don't hardcode colors like this -- it will conflict with dark mode (or light mode, or whatever theme the user has selected).
| <number>4</number> | ||
| </property> | ||
| <property name="styleSheet"> | ||
| <string>QLabel { background-color: #aaaaaa; }</string> |
| </widget> | ||
| </item> | ||
| <item> | ||
| <widget class="QLabel" name="line2"> |
There was a problem hiding this comment.
Are these the gray bars that are separating the different groups of buttons? Those are not a standard user-interface element in FreeCAD -- instead, just use a small spacer, don't try to color it.
| <property name="text"> | ||
| <string>Download</string> | ||
| <string>Close</string> |
There was a problem hiding this comment.
I don't think a Close button is needed in this dialog. It's already quite cluttered, and it's not actually really clear what "Close" means in this context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No
.cppchanges — all widget object names are preserved, so all existing signal/slot connections and logic remain intact.Test plan
🤖 Generated with Claude Code