Skip to content

fix issue 2#14

Open
watermelon-neko wants to merge 2 commits intoswe-productivity:masterfrom
watermelon-neko:pr2
Open

fix issue 2#14
watermelon-neko wants to merge 2 commits intoswe-productivity:masterfrom
watermelon-neko:pr2

Conversation

@watermelon-neko
Copy link
Copy Markdown

@watermelon-neko watermelon-neko commented Feb 15, 2026

result

fix #2

image

@timon-schelling timon-schelling self-assigned this Feb 18, 2026
@timon-schelling
Copy link
Copy Markdown
Collaborator

timon-schelling commented Feb 18, 2026

This was not tested well, the tools should produce the same visual result like on https://dev.graphite.art

When drawing a rectangle like along the line (upper corner to the viewport center) the scale of the resulting rectangle is still wrong (width, height and translation seem fine).

Have your viewport zoom at something smaller that 100% to reproduce this.

image image

what it should look like:
image
image

TL;DR: you only did one part of the issue, the second part keeping the scale at 1 still remains

@timon-schelling timon-schelling marked this pull request as draft February 18, 2026 14:02
@timon-schelling
Copy link
Copy Markdown
Collaborator

also it might be cleaner to introduce a helper function (in editor/src/messages/tool/common_functionality/utility_functions.rs) instead of duplicating the same code and leavening a comment.

@watermelon-neko watermelon-neko marked this pull request as ready for review February 25, 2026 14:53
@timon-schelling
Copy link
Copy Markdown
Collaborator

Will likely need some discussion with another maintainer, but I would like If you submit this upstream after the study.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drawing a shape at non-100% viewport zoom wrongly applies the scale to the Transform node not the shape

2 participants