feat: add Paykit private payments

[ben-kaufman]

Description

This PR adds private Paykit payments for saved contacts.

It:

1. Adds Paykit encrypted-link wrappers and a private Paykit service for contact link handshakes, recovery, private endpoint publishing, private endpoint fetching, and public fallback.
2. Reserves dedicated per-contact on-chain receive indexes and uses the new LDK address-info APIs to prevent private addresses from colliding with normal receive addresses.
3. Adds private Lightning invoice rotation, private on-chain rotation, contact/payment attribution, contact delete/sign-out/wipe cleanup, and backup/restore support for private link state plus reservation ceilings.
4. Updates contact payment entry points so saved contact sends prefer private Paykit when ready and fall back to public Paykit when private resolution is unavailable.
5. Adds focused private Paykit tests and a changelog fragment.

Linked Issues/Tasks

N/A

QA Notes

Manual Tests

• 1. Alice contact detail → Send to Bob saved contact: private on-chain payment opens and sends successfully.
• 2. Bob Activity → received payment from Alice: activity contact is set to Alice.
• 3. Bob private receive address → receive funds: private address rotates before it is republished to Alice.
• 4. Alice Contacts → delete Bob: private endpoint tombstone is sent and local private state is cleared after cleanup succeeds.
• 5. Bob Settings → copy seed → Dev Settings wipe → restore seed: wallet restores, private reservation ceiling is preserved, and the next normal receive address skips the reserved range.
• 6. regression: contact with no private-ready link → Send: public Paykit remains the fallback path when available.

Automated Checks

• git diff --check && git diff --cached --check
• swiftformat --lint on touched private Paykit/contact files
• node scripts/validate-translations.js
• Old Xcode targeted test: PrivatePaykitServiceTests passed, 12 tests, 0 failures
• Old Xcode app build with E2E flags passed during the final private Paykit verification pass

Screenshot / Video

N/A

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3dee822d5e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[piotr-iohk]

Observations from initial testing round:

1. encountered "Duplicate payment" on private ln send. (After few sends between private contacts)
Alice-> Bob
Bob -> Alice
Alice: bitkit_logs_2026-05-14_12-43-46.zip
Bob: bitkit_logs_2026-05-14_12-43-30.zip

Screen.Recording.2026-05-14.at.14.40.31.mov

---

2. seems that sometimes the payment falls back to public(?) ("Received from..." is not appearing on the Recepient's activity list)
See payments between Paykit Sender and Alice C:

Paykit Sender: bitkit_logs_2026-05-14_12-02-47.zip
Alice C: bitkit_logs_2026-05-14_12-02-28.zip

Screen.Recording.2026-05-14.at.13.58.13.mov

---

3. As shown in the recording above, the payment button sometimes appears after a short delay. A similar delay can also be observed when tapping the contact’s pay icon. This is just an observation for now.

---

4. Private Paykit fallback / stale link observation

I could not reproduce this reliably yet, but I hit it once on an older wallet that already had funds.

Rough flow was:

• Bob had an existing funded wallet.
• Bob created a Pubky profile.
• Paykit Sender added Bob as a contact.
• Bob added Paykit Sender as a contact.
• Bob attempted to pay that contact -> resulted in "Payment failed" toast
• In Bob’s logs, private Paykit resolution failed with a Noise decryption error, after which the app fell back to public Paykit:

failed to receive private payments: DecryptionError: pubky-noise receive_message failed: DecryptionError
Discarding cached private Paykit endpoints...
Falling back to public Paykit...

Bob: bitkit_logs_2026-05-14_11-11-10.zip
Paykit Sender: bitkit_logs_2026-05-14_12-02-47.zip

[ben-kaufman]

@piotr-iohk about 2 and 4, I've made some fixes to improve reliability of the connection, but note that in case of failure the silent fallback to public payments is expected. Issues 1 and 3 should be fixed now too.

[piotr-iohk]

Testing on latest revision.
Alice is iOS. Bob is Android.
Both exchanged some onchain private transactions.
For both lightning channel was created after they became contacts.

• Able to send from Bob to Alice (but seems to fall back to public)
• Not able to send from Alice to Bob.
• At the same time able to send from Alice to Bob via LN invoice.

Alice (iOS): bitkit_logs_2026-05-15_13-15-54.zip
Bob (Android): logs.zip

Screen.Recording.2026-05-15.at.15.14.12.mov

[piotr-iohk]

Testing on latest revision.

1.
Alice is iOS. Bob is Android.
Both exchanged some onchain private transactions.
For both lightning channel was created after they became contacts.

It seems that most of the payments I make are public - randomly I'm able to send private payment but then it falls back to public again. Didn't observe the previous issue with not being able to send though.

Alice: bitkit_logs_2026-05-15_15-29-40.zip
Bob: logs.zip

Side note: the current UX may undersell private Paykit if the only visible difference is “Received from”; we may want a clearer “Private payment” indicator or fallback label so users understand when a payment used a private contact endpoint versus public Paykit. 🤷

---

2.
Alice is iOS. Bob is Android.

Profiles created after both had onchain and spending balance ready.
Pretty much the same as in case 1 - most payments are public despite both are contacts.
Additionally I had a situation where after sending successfully private ln payment (Bob reports as "Received from Alice") the next payment only allowed onchain - and was also reported as private. All subsequent seem to be public.

Alice: bitkit_logs_2026-05-15_16-33-12.zip
Bob: logs.zip

---

3.
Unrelated, but probably easy fix (seems iOS specific, Android doesn't show it in this case). Dynamic contacts intro sheet appears even if profile has contacts already.

Screen.Recording.2026-05-15.at.16.53.58.mov

[ben-kaufman]

About the onchain only point after LN payment, so the way it works is if the invoice was already used but no new one was published by the peer yet it discards it so only onchain shows as available. I'll check why it didn't refresh fast enough to a new private invoice though.

[ben-kaufman]

I'm not yet 100% sure but I think this pubky/pubky-noise#17 should solve the private payments unreliability issue, once merged I'll make a new Paykit release and update the PRs. From local testing I didn't get the issue, but it wasn't happening reliably also before the fix so hard to be completely sure.

Other UI point should be resolved.