Skip to content

feat: facts widget v61 + OS widget#552

Open
pwltr wants to merge 1 commit into
feat/blocks-v61from
feat/facts-v61
Open

feat: facts widget v61 + OS widget#552
pwltr wants to merge 1 commit into
feat/blocks-v61from
feat/facts-v61

Conversation

@pwltr
Copy link
Copy Markdown
Contributor

@pwltr pwltr commented May 15, 2026

Description

This PR:

  1. Adds small and medium Bitcoin Facts home screen widgets.
  2. Updates the in-app Bitcoin Facts widget to match the new text-and-logo design, including small and wide previews.
  3. Removes obsolete Bitcoin Facts customization state now that the source row is no longer part of the design.
  4. Reuses the existing localization files for the home screen widget metadata.

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.17.-.2026-05-15.at.21.21.15.mov

QA Notes

Manual Tests

  • 1. Widgets → Bitcoin Facts: small and wide in-app previews render with fact text and Bitcoin logo.
  • 2. Widgets → Bitcoin Facts → Save Widget: widget can be added and removed without edit options.
  • 3. Home screen → add Bitcoin Facts small widget: fact text and logo render correctly in normal mode.
  • 4. Home screen → add Bitcoin Facts medium widget: fact text and top-right logo render without overlap.
  • 5. Home screen → switch to tinted widget mode: Bitcoin Facts logo remains visible.
  • 6. regression: widget gallery: Bitcoin Facts name and description are localized instead of showing raw keys.

@pwltr pwltr requested review from jvsena42 and piotr-iohk May 15, 2026 19:23
@pwltr pwltr changed the title feat: add bitcoin facts widgets feat: facts widget v61 + OS widget May 15, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e3af505404

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +137 to +138
.configurationDisplayName("widgets__facts__name")
.description("widgets__facts__description")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid shipping unresolved localization keys in widget metadata

Using localization keys directly in the widget configuration causes raw keys to appear for locales where these entries are missing in Bitkit/Resources/Localization/*/Localizable.strings (for example ar, el, and pt for widgets__facts__name, plus several locales for widgets__facts__description). Unlike the app’s t(...) helper, WidgetKit doesn’t apply your English fallback logic here, so affected users will see widgets__facts__... in the system widget gallery instead of readable text.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant