feat: add contact payment UI#553
Open
ben-kaufman wants to merge 1 commit into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c15ee26c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ben-kaufman
force-pushed
the
codex/private-payments-contact-ui
branch
2 times, most recently
from
fccb47f to
42aba93
Compare
ben-kaufman
force-pushed
the
codex/private-payments-contact-ui
branch
from
42aba93 to
c55532d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the contact-payment UI that was intentionally left out of the private Paykit PR:
This targets
codex/paykit-private-paymentsso it can be reviewed separately from the private Paykit core work.Linked Issues/Tasks
Refs #539
Screenshot / Video
Not attached in this PR body. The UI was validated locally against the simulator flow, and this branch is intentionally scoped to UI/wiring on top of the private payments branch.
Verification
swiftformat --lint Bitkit/Services/PrivatePaykitService+Endpoints.swift Bitkit/ViewModels/SettingsViewModel.swift Bitkit/Views/Settings/General/PaymentPreferenceView.swift Bitkit/Views/Wallets/Activity/ActivityRow.swift Bitkit/Views/Wallets/Activity/ActivityItemView.swift Bitkit/Views/Wallets/Send/SendContactSelectView.swift Bitkit/Views/Wallets/Send/SendOptionsView.swift Bitkit/Views/Wallets/Send/SendSheet.swift Bitkit/Views/Wallets/Activity/AssignActivityContactView.swift Bitkit/Components/PubkyContactAvatar.swift Bitkit/Components/PubkyContactRow.swiftgit diff --checkgit diff --cached --checknode scripts/validate-translations.jsenv DEVELOPER_DIR=/Users/benk10/Downloads/Old\ Mac\ Backup/Xcode.app/Contents/Developer xcodebuild -quiet -project Bitkit.xcodeproj -scheme Bitkit -configuration Debug -destination id=15FE6795-02FB-4073-A427-63F0B39A3A17 -derivedDataPath /private/tmp/bitkit-contact-ui-build build