fix: make hash_paths work when base_path is set#723
Merged
bhearsum merged 1 commit intotaskcluster:mainfrom Jul 23, 2025
Merged
fix: make hash_paths work when base_path is set#723bhearsum merged 1 commit intotaskcluster:mainfrom
hash_paths work when base_path is set#723bhearsum merged 1 commit intotaskcluster:mainfrom
Conversation
Since taskcluster#664 we started returning paths relative to the repository root from `_find_matching_files`. This meant that when we join `base_path` with `path` in `hash_paths`, we end up with `base_path` in there twice. Fixing this without breaking `mozpath.match` means we need to join together the repository root and matched files after `mozpatch.match`. This, in turn, requires that some tests are able to call `get_repository`, which requires faking a repository being present.
bhearsum
force-pushed
the
push-zusolxwrqukk
branch
from
5b946b7 to
c3717c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #664 we started returning paths relative to the repository root from
_find_matching_files. This meant that when we joinbase_pathwithpathinhash_paths, we end up withbase_pathin there twice.Fixing this without breaking
mozpath.matchmeans we need to join together the repository root and matched files aftermozpatch.match. This, in turn, requires that some tests are able to callget_repository, which requires faking a repository being present.As far as I can tell, this hasn't worked since #664, and possibly before that. We have very little usage of this function though, and I couldn't find any that used directories.