feat: Add SFTP connection reset method#1885
Open
MizouziE wants to merge 3 commits intothephpleague:3.xfrom
Open
feat: Add SFTP connection reset method#1885MizouziE wants to merge 3 commits intothephpleague:3.xfrom
MizouziE wants to merge 3 commits intothephpleague:3.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
League\Flysystem\PhpseclibV3\SftpConnectionProvider::resetConnection()method which leverages existing publicdisconnect()and privatesetupConnection()methods.provideConnection()differs from that returned byresetConnection()and that subsequent calls toprovideConnection()return the re-initiated connection.Reasoning
An application I work on has a Laravel/Symfony Command which is used to diagnose various connections to SFTP servers and we would prefer to keep the logs for each test action separate. Currently we need to flush and re-establish the connection for each step. This addition would allow us to configure the connection once and reset it for each test action.