Enhance port handling in Address and Ports classes.#20
Merged
gustavofreze merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the container address port model to distinguish between container-internal exposed ports and host-mapped ports by reading NetworkSettings.Ports from docker inspect, surfacing host ports via the Ports contract, and documenting/testing the new behavior.
Changes:
- Parse host port bindings from
docker inspect(NetworkSettings.Ports) and store them alongside exposed ports. - Extend the
Portscontract + implementation withhostPorts()andfirstHostPort(). - Add unit tests and README examples covering host port mappings, multiple mappings, and null bindings.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Unit/Mocks/InspectResponseFixture.php | Adds NetworkSettings.Ports to fixtures so tests can simulate host port bindings. |
| tests/Unit/GenericDockerContainerTest.php | Adds unit coverage for host port parsing and new Ports API. |
| src/Internal/Containers/ContainerInspection.php | Extracts host-mapped ports from inspect payload and wires them into Address. |
| src/Internal/Containers/Address/Ports.php | Stores exposed vs host-mapped ports separately and exposes new accessors. |
| src/Contracts/Ports.php | Public contract update to include host port access methods. |
| README.md | Documents how to access container vs host ports after start. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.