Skip to content

Fix fine-tuning metrics CLI zero filters#374

Merged
blainekasten merged 3 commits into
nextfrom
cursor/cli-sdk-updates-cb66
May 20, 2026
Merged

Fix fine-tuning metrics CLI zero filters#374
blainekasten merged 3 commits into
nextfrom
cursor/cli-sdk-updates-cb66

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor Bot commented May 20, 2026

Target base branch: next.

Summary

  • Preserve explicit zero values for fine-tuning list-metrics integer filters when forwarding to the SDK.
  • Add CLI coverage asserting --global-step-from 0 and --global-step-to 0 reach the /fine-tunes/{id}/metrics request.

Tests

  • python3 -m pytest tests/cli/test_fine_tuning.py tests/test_plots_engine.py -q
  • python3 -m ruff check src/together/lib/cli/api/fine_tuning/list_metrics.py tests/cli/test_fine_tuning.py

Reviewers requested: @blainekasten, @artek0chumak

Open in Web View Automation 

@blainekasten blainekasten changed the base branch from main to next May 20, 2026 16:48
@blainekasten blainekasten marked this pull request as ready for review May 20, 2026 17:10
@blainekasten
Copy link
Copy Markdown
Contributor

@cursoragent rebase next in here

@cursor
Copy link
Copy Markdown
Contributor Author

cursor Bot commented May 20, 2026

Taking a look!

Open in Web Open in Cursor 

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@cursor cursor Bot force-pushed the cursor/cli-sdk-updates-cb66 branch from fd5cfc3 to b1fb4de Compare May 20, 2026 17:11
@blainekasten
Copy link
Copy Markdown
Contributor

@cursoragent tests are failing - figure out what to do

@cursor
Copy link
Copy Markdown
Contributor Author

cursor Bot commented May 20, 2026

Handled.

What happened:

  • Old failing head b1fb4de6: test-others failed because Python 3.10 couldn’t parse CLI datetime input ending in Z.
  • I fixed that in 490dff12.
  • New push then failed lint because ruff format --check wanted tests/cli/test_fine_tuning.py reformatted.
  • I ran ruff format, committed/pushed a3464b57 Format fine tuning CLI test, and updated the PR.

Current CI:

  • Push run for a3464b57: all passing
    • build
    • test-others
    • test-integration
    • lint
  • PR run also green for its required path.

Working tree clean.

Open in Web Open in Cursor 

cursoragent and others added 2 commits May 20, 2026 17:15
Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@blainekasten blainekasten merged commit acf7bc9 into next May 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants