PM-5065 - allow projectIds[] param for fetching challenges#107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for filtering challenges by multiple project IDs in the API and updates the access control logic to treat such queries as having project manager access (with the expectation that only accessible project IDs are provided). The changes update the API documentation, validation schema, query filtering logic, and authorization handling.
API and Filtering Enhancements:
projectIdsquery parameter to the API, allowing clients to filter challenges by multiple project IDs. The parameter is documented as an array using repeated query params (e.g.,projectIds[]=1&projectIds[]=2) indocs/swagger.yaml.searchChallenges.schemato accept an array of positive integers for the newprojectIdsfilter.ChallengeService.jsto apply anINfilter whenprojectIdsis specified, enabling efficient filtering by multiple projects.Authorization Logic:
projectIdsas having project manager access, under the assumption that the caller only passes project IDs they are authorized to access.