PM-5075 - use the user skill summary table#101
Merged
Conversation
kkartunov
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the
MemberSearchServiceinmember-search.service.tsby removing unnecessary initialization logic and refactoring how skill win and submission data are queried. The changes improve maintainability and performance by leveraging a precomputed summary table and streamlining the query structure.Service Initialization Simplification:
OnModuleInitlifecycle hook and related asynchronous initialization logic for loading skill event and engagement source type IDs. The service no longer stores these IDs in instance variables.Database Query Refactoring:
skills.user_skill_win_summarytable, simplifying the SQL and reducing query complexity.user_match_dataonly if skills are specified, improving query efficiency when no skills are provided.