Skip to content

[AP-2965] Update to prepare for Python 3.12#160

Merged
tw-census merged 23 commits into
masterfrom
AP-2965_for_py312
Apr 17, 2026
Merged

[AP-2965] Update to prepare for Python 3.12#160
tw-census merged 23 commits into
masterfrom
AP-2965_for_py312

Conversation

@amofakhar
Copy link
Copy Markdown
Contributor

@amofakhar amofakhar commented Apr 16, 2026

Description of change

Some update to prepare it for Python 3.12 and making a new release.

https://transferwise.atlassian.net/browse/AP-2965

Context

Some update to prepare it for Python 3.12 and making a new release.

https://transferwise.atlassian.net/browse/AP-2965

Manual QA steps

  • Nothing

Risks

  • Breaking current pipelinewise taps

Rollback steps

  • revert this branch

Copilot AI review requested due to automatic review settings April 16, 2026 15:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Changes: Maintenance (1)

This PR updates the package metadata and CI configuration to target Python 3.12 as part of AP-2965.

Changes:

  • Bump package version to 3.0.0 and adjust declared supported Python version(s) in setup.py.
  • Update GitHub Actions CI matrix/default Python version to include Python 3.12.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
setup.py Updates package version and python_requires for Python 3.12 support.
.github/workflows/main.yml Updates CI test matrix and coverage job Python version to include 3.12.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread setup.py Outdated
Comment thread .github/workflows/main.yml Outdated
Comment thread .github/workflows/main.yml
@amofakhar amofakhar changed the title [AP-2965] Update for Python 3.12 [AP-2965] Update to prepare for Python 3.12 Apr 16, 2026
@amofakhar amofakhar added the python Pull requests that update Python code label Apr 16, 2026
@amofakhar
Copy link
Copy Markdown
Contributor Author

amofakhar commented Apr 17, 2026

/wise_bot run-checks

@wise-github-bot-app
Copy link
Copy Markdown

🟢

All checks were successfully run, except for the wise/vulnerability-sla check. To run this check, please manually re-run the generate_sbom workflow from the Actions tab.

naomiwise
naomiwise previously approved these changes Apr 17, 2026
@wise-github-bot-app
Copy link
Copy Markdown

The approval(s) from naomiwise do(es)n't fullfill the approvers requirements because:

  • The approver's cost centre, ENGPLA, maps to the PLATFORM business function. As the code that was changed is owned by ENGINEERING, this approval won't satisfy our separation of duties check. We'll need an additional approval from someone in ENGINEERING. This approval may still help satisfy other codeowner requirements.

louis-pie
louis-pie previously approved these changes Apr 17, 2026
koszti
koszti previously approved these changes Apr 17, 2026
@wise-github-bot-app
Copy link
Copy Markdown

The approval(s) from koszti do(es)n't fullfill the approvers requirements because:

  • The approver's cost centre, ENGPLA, maps to the PLATFORM business function. As the code that was changed is owned by ENGINEERING, this approval won't satisfy our separation of duties check. We'll need an additional approval from someone in ENGINEERING. This approval may still help satisfy other codeowner requirements.

caiocsgomes
caiocsgomes previously approved these changes Apr 17, 2026
Copy link
Copy Markdown
Member

@caiocsgomes caiocsgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wise-github-bot-app
Copy link
Copy Markdown

The approval(s) from caiocsgomes do(es)n't fullfill the approvers requirements because:

  • The approver's cost centre, ENGPLA, maps to the PLATFORM business function. As the code that was changed is owned by ENGINEERING, this approval won't satisfy our separation of duties check. We'll need an additional approval from someone in ENGINEERING. This approval may still help satisfy other codeowner requirements.

@amofakhar amofakhar dismissed stale reviews from caiocsgomes and koszti via a782795 April 17, 2026 11:56
@caiocsgomes
Copy link
Copy Markdown
Member

/wise-bot broken-config-merge fixing team name in codeowners file

@wise-github-bot-app
Copy link
Copy Markdown

🔴

The broken config merge can only be requested if the PR is only changing the CODEOWNERS or tw-rules file.

@caiocsgomes
Copy link
Copy Markdown
Member

/wise-bot misc-emergency-merge fixing team name in codeowners file

@wise-github-bot-app
Copy link
Copy Markdown

🔴

An approval from a member of the security squad is required for an misc-emergency merge. Please reach out on #security (or #security-engineering).

@bh-wise

This comment was marked as low quality.

@wise-github-bot-app
Copy link
Copy Markdown

🔴

Sorry, you have to be an owner of the repository to ask for a misc-emergency merge

@wise-github-bot-app
Copy link
Copy Markdown

The approval(s) from bh-wise do(es)n't fullfill the approvers requirements because:

  • The approver's cost centre, ENGSEC, maps to the GOVERNANCE business function. As the code that was changed is owned by ENGINEERING, this approval won't satisfy our separation of duties check. We'll need an additional approval from someone in ENGINEERING. This approval may still help satisfy other codeowner requirements.

@crablab
Copy link
Copy Markdown

crablab commented Apr 17, 2026

/wise-bot misc-emergency-merge "Unblock broken CODEOWNERS"

@wise-github-bot-app
Copy link
Copy Markdown

🟢

An approval from a member of the security squad has been received.

@wise-github-bot-app
Copy link
Copy Markdown

🟢

Emergency merge (MISC_EMERGENCY_MERGED) requested by crablab.

This event has been added to the security log. The merge could take few seconds...

Remember that, once it is merged, a maintainer should review the code and approve it retrospectively by commenting /wise-bot approve within 3 days to avoid an SLA breach.

Requester crablab
Reason "Unblock broken CODEOWNERS"
Merge Method squash

@wise-github-bot-app
Copy link
Copy Markdown

🔴

Sorry, I couldn't merge the PR, check the logs for more info... 😢

HttpError: Not Found

@naomiwise
Copy link
Copy Markdown

/wise-bot misc-emergency-merge "Unblock broken CODEOWNERS"

@wise-github-bot-app
Copy link
Copy Markdown

🟢

An approval from a member of the security squad has been received.

@wise-github-bot-app
Copy link
Copy Markdown

🟢

Emergency merge (MISC_EMERGENCY_MERGED) requested by naomiwise.

This event has been added to the security log. The merge could take few seconds...

Remember that, once it is merged, a maintainer should review the code and approve it retrospectively by commenting /wise-bot approve within 3 days to avoid an SLA breach.

Requester naomiwise
Reason "Unblock broken CODEOWNERS"
Merge Method squash

@tw-census tw-census merged commit 3e46097 into master Apr 17, 2026
7 of 8 checks passed
@tw-census tw-census deleted the AP-2965_for_py312 branch April 17, 2026 16:30
@wise-github-bot-app
Copy link
Copy Markdown

Your CODEOWNERS or the tw-rules.yaml file has changed. Syncing your GitHub teams with your CODEOWNERS file and extraWriters in tw-rules:

Collaborator Name Status Comment
analytics-platform 🟢 Team updated with role owner
Samira-El 🟡 Unexpected User would be deleted with strict access

You have more info in the docs

@CountryTk
Copy link
Copy Markdown

/wise-bot approve

@wise-github-bot-app
Copy link
Copy Markdown

Approved by CountryTk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:approved change:misc_emergency python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants