fix(mpls): print stack flag without suffix#595
Open
Komzpa wants to merge 1 commit intotraviscross:masterfrom
Open
fix(mpls): print stack flag without suffix#595Komzpa wants to merge 1 commit intotraviscross:masterfrom
Komzpa wants to merge 1 commit intotraviscross:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a small MPLS report formatting issue found while following up on analyzer/format warnings.
The IP-info report helper used
%cufor the bottom-of-stack field, which can print an extra literaluafter the value. The other MPLS output paths print this field as an unsigned numeric flag, so this switches the helper to%uand casts the small integer fields explicitly.The curses MPLS output gets the same explicit casts for consistency with the report/raw output format handling.
Validation
make clean >/tmp/mtr-make-clean.log && make -j "$(nproc)"git diff --checksudo python3 ./test/cmdparse.pyTracked issues closed: none. This is static-analysis/format follow-up cleanup.