ecmascript(temporal): PlainTime.prototype.add + subtract#979
Merged
aapoalas merged 7 commits intotrynova:mainfrom Apr 14, 2026
Merged
ecmascript(temporal): PlainTime.prototype.add + subtract#979aapoalas merged 7 commits intotrynova:mainfrom
aapoalas merged 7 commits intotrynova:mainfrom
Conversation
aapoalas
previously approved these changes
Apr 12, 2026
Member
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
LGTM! I'll run the tests and update expectations for you.
aapoalas
reviewed
Apr 14, 2026
Co-authored-by: Aapo Alasuutari <aapo.alasuutari@gmail.com>
…_prototype.rs Co-authored-by: Aapo Alasuutari <aapo.alasuutari@gmail.com>
…_prototype.rs Co-authored-by: Aapo Alasuutari <aapo.alasuutari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decided to put both add and subtract in one PR since they depend on the same helper and are basically identical. They are added in two separate commits however. Did not run the tests as they wont work on my machine anyways :(