feat: implement specialized layout for decoupling capacitors#77
Open
sumithkumar07 wants to merge 1 commit into
Open
feat: implement specialized layout for decoupling capacitors#77sumithkumar07 wants to merge 1 commit into
sumithkumar07 wants to merge 1 commit into
Conversation
|
@sumithkumar07 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specialized Decoupling Capacitor Layout Implementation
This PR addresses Issue #15 by implementing a specialized layout logic for decoupling capacitors to ensure they are placed in clean, logical rows near their respective main chips.
Changes Made
1. Enhanced Partitioning Logic
ChipPartitionsSolverto include a fallback detection method for decoupling capacitors. This ensures that even if metadata is missing, components with 2 pins on y+/y- sides that are strongly connected to complex chips are correctly identified.decoupling_capspartitions.2. Specialized Inner Packing
SingleInnerPartitionPackingSolverspecifically fordecoupling_capspartitions.3. Global Packing Optimization
PartitionPackingSolverto use theshortest_connection_along_outlinestrategy. This prevents the capacitor groups from being placed directly on top of the main chip while maintaining high proximity.Verification Results
Automated Tests
RP2040Circuit.test.ts.Visual Comparison (Theoretical)