Skip to content

Reinstate parallelism for local builds#7728

Merged
smillst merged 6 commits into
typetools:masterfrom
mernst:parallel-build
May 20, 2026
Merged

Reinstate parallelism for local builds#7728
smillst merged 6 commits into
typetools:masterfrom
mernst:parallel-build

Conversation

@mernst
Copy link
Copy Markdown
Member

@mernst mernst commented May 17, 2026

No description provided.

@mernst mernst linked an issue May 17, 2026 that may be closed by this pull request
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 17, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 63aed264-e6a3-4577-a20a-1287d9a4d277

📥 Commits

Reviewing files that changed from the base of the PR and between 58e5025 and ba115e0.

📒 Files selected for processing (1)
  • build.gradle

📝 Walkthrough

Walkthrough

The PR updates build.gradle to set per-fork parallelism for Gradle Test tasks unless running under CI. If any of TF_BUILD, CIRCLECI, GITHUB_ACTIONS, or CI env vars are present, all Test tasks use maxParallelForks = 1 and forkEvery = 25; otherwise maxParallelForks is set to the available processor count (fallback 1).

Possibly related issues

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

msridhar
msridhar previously approved these changes May 17, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@build.gradle`:
- Around line 997-1000: The environment check in the if-condition that reads
System.getenv("GITHUB_ACTION") should be changed to the documented boolean
variable System.getenv("GITHUB_ACTIONS"); update the conditional that contains
System.getenv("TF_BUILD"), System.getenv("CIRCLECI"),
System.getenv("GITHUB_ACTION") and System.getenv("CI") to use "GITHUB_ACTIONS"
instead of "GITHUB_ACTION" so the CI detection in build.gradle correctly detects
GitHub Actions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 51c52439-8e28-4cef-8631-e703357bb153

📥 Commits

Reviewing files that changed from the base of the PR and between 6db33fb and 02997a5.

📒 Files selected for processing (1)
  • build.gradle

Comment thread build.gradle
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@build.gradle`:
- Line 1013: The maxParallelForks assignment uses a non-existent Runtime.runtime
API; update the expression that sets maxParallelForks to call
Runtime.getRuntime().availableProcessors() and fall back to 1 if needed (i.e.,
replace the Runtime.runtime.availableProcessors() usage with
Runtime.getRuntime().availableProcessors() in the maxParallelForks assignment).
- Around line 1008-1010: Inside the existing tasks.withType(Test) configuration
remove the nested tasks.withType(Test) block and set forkEvery = 25 directly in
the outer tasks.withType(Test) scope (i.e., update the configuration that
currently contains forkEvery inside another tasks.withType(Test)); also replace
the incorrect Runtime.runtime.availableProcessors() call with
Runtime.getRuntime().availableProcessors() so the code uses the static
getRuntime() method to obtain the Runtime instance.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b43372ce-6854-4d10-9ef8-74be74bea949

📥 Commits

Reviewing files that changed from the base of the PR and between 02997a5 and 58e5025.

📒 Files selected for processing (1)
  • build.gradle

Comment thread build.gradle Outdated
Comment thread build.gradle Outdated
@msridhar msridhar removed their assignment May 19, 2026
@msridhar
Copy link
Copy Markdown
Contributor

@mernst are we good to merge this one? Or would you like an additional review from @smillst?

@mernst
Copy link
Copy Markdown
Member Author

mernst commented May 19, 2026

@msridhar Yes, I am waiting for a review by @smillst.

@smillst smillst merged commit 791593e into typetools:master May 20, 2026
35 checks passed
@smillst smillst deleted the parallel-build branch May 20, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parallel test execution disabled locally

3 participants