Catch inconsistent test namespaces in CircleCI.#1795
Merged
aaronweeden merged 2 commits intoDec 7, 2023
Merged
Conversation
aaronweeden
added
the
maintenance / code quality
aaronweeden
force-pushed
the
fix-warehouse-raw-data-regression-test-namespace
branch
from
71f80aa to
06d4945
Compare
aaronweeden
force-pushed
the
fix-warehouse-raw-data-regression-test-namespace
branch
from
06d4945 to
4d35431
Compare
aaronweeden
changed the title
aaronweeden
requested review from
aestoltm,
connersaeli,
eiffel777,
jpwhite4 and
ryanrath
6 tasks
eiffel777
approved these changes
Dec 7, 2023
aaronweeden
deleted the
fix-warehouse-raw-data-regression-test-namespace
branch
This was referenced Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a CircleCI step to automatically catch inconsistent test namespaces so that the manual test from #1789 doesn't need to be performed.
This PR also fixes the namespace of
tests/regression/lib/Rest/WarehouseRawDataTest.phpto be consistent with the other test files. That file was added in #1788 after #1789 had already been merged, so it was not caught when manually checking the namespaces for #1789.Tests performed
To make sure the CircleCI step worked, I first committed just
.circleci/config.ymlto make sure it failed, then committed the change totests/regression/lib/Rest/WarehouseRawDataTest.phpto make sure it passed.Checklist: