Wordwrap long legends#2128
Open
aestoltm wants to merge 19 commits into
Open
Conversation
aestoltm
added
enhancement
aestoltm
force-pushed
the
wordwrap_long_legends
branch
from
1112d73 to
26d783c
Compare
…Export Update caused some issues
…r, if a single word is over the character limit then we must hyphenate that word
jpwhite4
reviewed
Apr 15, 2026
| ) { | ||
| $rank = $meDataSeries['legendrank'] / 3; | ||
| $meDataSeries['name'] = "${rank}. " . $meDataSeries['name']; | ||
| $meDataSeries['oname'] = "${rank}. " . $meDataSeries['oname']; |
Member
There was a problem hiding this comment.
I don't quite understand the need to add yet another parameter to the chart config that is a copy of an existing parameter. The word wrapping is all done in the javascript, so why do you need a new parameter?
Also (assuming this new parameter is necessary): Is this going to cause breakage with existing saved charts? or with charts saved in the report generator?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on PR #2127 . Will also require PRs on the various XDMoD modules (https://github.com/ubccr/xdmod-xsede/pull/1099 and ubccr/xdmod-appkernels#145).
Add word wrapping to long legend entries. Plotly JS does not support automatic word wrap on legends, therefore, we have to pragmatically determine the word wrap condition based on the chart div width (also including when we resize the browser window).
Before:
After:
Motivation and Context
Long legends were unviewable before, especially detrimental for exported charts
Tests performed
Tested on dev port
Checklist: