docs: install qtc via go install instead of the dropped go get -u#106
Open
c-tonneslan wants to merge 1 commit into
Open
docs: install qtc via go install instead of the dropped go get -u#106c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
go get -u no longer installs binaries since Go 1.16. On a modern toolchain the README's instructions silently do nothing and qtc never lands on $PATH, which is what tripped up valyala#94. Switch the package install to plain go get and the qtc install (and the go:generate snippet) to go install ...@latest, which is the documented replacement. Closes valyala#94. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #94.
`go get -u` no longer installs binaries since Go 1.16. On a modern toolchain the README's instructions silently do nothing and `qtc` never lands on $PATH (that's what tripped up the issue reporter). Switch the package install to plain `go get` and the `qtc` install (and the `go:generate` snippet) to `go install ...@latest`, which is the documented replacement.