Removed ERROR_COMMITMENT_WITHIN_UNBONDING_PERIOD#8
Open
chrishobcroft wants to merge 1 commit into
Open
Conversation
Removed the check of whether the buyer was committing to buy within the calculated `UnbondingPeriodLength` (calculated as unbondingRounds * roundLength). This was excessively constraining, e.g. if a buyer commits 2000 blocks (~7.5 hours) before the end of round N, and the `deliveredByBlock` was 2000 blocks into round N+U-1, then this constraint would have prohibited the order from being committed to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the check of whether the buyer was committing to buy within the calculated
UnbondingPeriodLength(calculated as unbondingRounds * roundLength).This was excessively constraining, e.g. if a buyer commits 2000 blocks (~7.5 hours) before the end of round N, and the
deliveredByBlockwas 2000 blocks into round N+U-1 (-1 because if you unbond in the current round, then this round counts towards the unbonding period), then this constraint would have prohibited the order from being committed to, even though it would have been fine.So, while this solution was unnecessarily restrictive, I have proposed some ideas for a more elegant solution in this research issue.