Optimize xilinx_async_bram_patch.tcl#350
Open
eirikwitt wants to merge 1 commit into
Open
Conversation
This reduces the runtime complexity from O(x²) to O(x) by not searching through all cells when finding descendants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running my Synthesis-to-Bitstream flow targeting a u250 FPGA, the runtime can get into the 100's of hours for large configurations. More than 90% of this time is spent running the xilinx_async_bram_patch.tcl script.
This patch reduces the runtime complexity from O(x²) to O(x) by not searching through all cells when finding descendants.

This reduces the worst case runtime by 94% from ~120 hours to ~7 for a 16 core 2 cluster configuration.
I do not have access to working FPGAs to test the generated bitstreams, but I verified my changes by running this modified version of the script on a wide range of configurations.
NB: This was not tested using Vortex's makefiles, but a modified version of Chipyards makefiles as a part of an attempt to run Vortex using FireSim, so results may vary.