fix: propagate --conversation to SpawnAgentRequest for run-cloud#10524
Draft
liliwilson wants to merge 1 commit intomasterfrom
Draft
fix: propagate --conversation to SpawnAgentRequest for run-cloud#10524liliwilson wants to merge 1 commit intomasterfrom
liliwilson wants to merge 1 commit intomasterfrom
Conversation
conversation_id was hardcoded to None in the run-cloud path, so the flag was parsed but never sent to the server. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
--conversationflag onagent run-cloudwas parsed but never propagated to theSpawnAgentRequest. Theconversation_idfield was hardcoded toNoneinambient.rs, so the server never received the conversation context.Fix: pass
args.conversationthrough toSpawnAgentRequest.conversation_id.Linked Issue
REMOTE-1633
The linked issue is labeled
ready-to-specorready-to-implement.Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).
Testing
Added a CLI-level test (
agent_run_cloud_accepts_conversation_flag) that verifies--conversationparses correctly forrun-cloud../script/runAgent Mode
Conversation: https://staging.warp.dev/conversation/02bfb4e3-783a-4ded-bb6a-52792364f74c
Run: https://oz.staging.warp.dev/runs/019e09ad-52e8-774e-afb0-0a561b8aa219
This PR was generated with Oz.