Skip to content

Fix keywrap response size checks#359

Open
padelsbach wants to merge 1 commit into
wolfSSL:mainfrom
padelsbach:keywrap-respsize-checks
Open

Fix keywrap response size checks#359
padelsbach wants to merge 1 commit into
wolfSSL:mainfrom
padelsbach:keywrap-respsize-checks

Conversation

@padelsbach
Copy link
Copy Markdown
Contributor

@padelsbach padelsbach commented May 11, 2026

And add unit tests.

Fixes F-3104

@@ -0,0 +1,232 @@
/*
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New test case might be overkill for these simple fixes -- tried to keep them as simple as possible...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I also dont like the idea of having fake transport spoofing style tests just to ensure we are checking args correctly. Does smell like overkill, at least for now.

Lets phrase the problem in a different manner - assume we want to eventually get to 100% code coverage...given the new test framework, how would we structure it such that the higher level behavioral integration tests can be somewhat isolated from the API/unit/spammy style tests that just ensure "assert" behavior on args.

Does it make sense to have a totally separate group of "API/arg" tests, also organized by module?

I know this is overkill to discuss this for such a small PR but I'd rather iron these details out up front as we are integrating.

Thoughts?

@padelsbach padelsbach force-pushed the keywrap-respsize-checks branch from 8f9dbf9 to 937002e Compare May 14, 2026 18:10
@padelsbach padelsbach marked this pull request as ready for review May 14, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants