quickfix: output size propagation#373
Open
bigbrett wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes output length propagation when crypto callback operations return WH_ERROR_BUFFER_SIZE, allowing callers to resize buffers and retry for RSA, ECDH, and Ed25519 sign paths.
Changes:
- Propagate updated
*out_len/*outLenon bothWH_ERROR_OKandWH_ERROR_BUFFER_SIZEfor RSA and ECDH paths. - Same propagation for Ed25519 sign, and convert previous
else ifchain to independentifchecks for error remapping.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+397
to
404
| if (((ret == WH_ERROR_OK) || (ret == WH_ERROR_BUFFER_SIZE)) && | ||
| (outLen != NULL)) { | ||
| *outLen = len; | ||
| } | ||
| else if (ret == WH_ERROR_BADARGS) { | ||
| if (ret == WH_ERROR_BADARGS) { | ||
| ret = BAD_FUNC_ARG; | ||
| } | ||
| else if (ret == WH_ERROR_NOTIMPL) { |
Comment on lines
+217
to
+220
| /* Propagate updated length on BUFFER_SIZE so callers can re-call | ||
| * with a sufficiently large output buffer. */ | ||
| if (((ret == WH_ERROR_OK) || (ret == WH_ERROR_BUFFER_SIZE)) && | ||
| (out_len != NULL)) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix output size propagation on errors for RSA/ED/ECDH/C25519