Skip to content

Tets#3

Draft
phongphongg wants to merge 2 commits into
v0from
feat/iam
Draft

Tets#3
phongphongg wants to merge 2 commits into
v0from
feat/iam

Conversation

@phongphongg
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 11, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 213885a4-767f-47f0-82ca-0a21210fcd4a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/iam

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the application's infrastructure by introducing a dedicated Helm chart for the Identity and Access Management (IAM) service. This change modularizes the IAM component, allowing for independent deployment and configuration, and integrates it seamlessly into the existing Kubernetes deployment pipeline. The update also ensures that dependent services, like 'desk', correctly reference the new IAM endpoint, laying the groundwork for a more scalable and maintainable authentication system.

Highlights

  • New IAM Helm Chart: Introduced a new Helm chart for the Identity and Access Management (IAM) service, modularizing its deployment.
  • Deployment Pipeline Integration: Integrated the new IAM Helm chart as a dependency in the main application's Chart.yaml and updated the deployment automation to include rollout status checks for the IAM service.
  • IAM Endpoint Configuration: Configured the IAM_ISSUER_URL in the desk service to correctly point to the newly deployed IAM service endpoint.
  • Global Configuration: Added top-level configuration for the IAM service's image and HTTP routing in the main values.yaml.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .github/actions/deploy/roles/workastra.Taskfile.yml
    • Added IAM service configuration to the deployment task.
    • Included a rollout status check for the workastra-iam deployment.
  • Chart.yaml
    • Added iam as a new dependency.
  • charts/desk/templates/configmap.yaml
    • Updated IAM_ISSUER_URL to reflect the new IAM service endpoint.
  • charts/iam/.helmignore
    • Added standard ignore patterns for the new iam Helm chart.
  • charts/iam/Chart.yaml
    • Created the Helm chart definition for the iam service.
  • charts/iam/templates/NOTES.txt
    • Added deployment notes for the iam Helm chart.
  • charts/iam/templates/_helpers.tpl
    • Added helper templates for naming and labels in the iam chart.
  • charts/iam/templates/deployment.yaml
    • Added the Kubernetes Deployment manifest for the iam service.
  • charts/iam/templates/hpa.yaml
    • Added the Horizontal Pod Autoscaler manifest for the iam service.
  • charts/iam/templates/httproute.yaml
    • Added the Gateway API HTTPRoute manifest for the iam service.
  • charts/iam/templates/ingress.yaml
    • Added the Kubernetes Ingress manifest for the iam service.
  • charts/iam/templates/service.yaml
    • Added the Kubernetes Service manifest for the iam service.
  • charts/iam/templates/serviceaccount.yaml
    • Added the Kubernetes ServiceAccount manifest for the iam service.
  • charts/iam/templates/tests/test-connection.yaml
    • Added a test connection manifest for the iam service.
  • charts/iam/values.yaml
    • Added default configuration values for the iam Helm chart.
  • values.yaml
    • Added global configuration for the iam service, including image and HTTP route settings.
Activity
  • No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Helm chart for the iam service and integrates it into the main application. The changes include adding the iam chart as a dependency, configuring its deployment and HTTP routing, and updating the desk service's IAM issuer URL to reflect the new setup. The overall structure for the new iam chart seems well-defined with standard Helm templates for deployment, service, HPA, and routing. However, there is a concern regarding the use of the latest tag for the iam image, which should be addressed for better deployment stability.

Comment thread values.yaml Outdated
iam:
image:
repository: "docker.io/workastra/platform/iam"
tag: "latest"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using the latest tag for container images in production deployments is generally discouraged. It can lead to unpredictable behavior and make rollbacks or debugging difficult, as the latest tag can change at any time. It's best practice to pin to a specific, immutable image tag (e.g., a semantic version or a commit SHA) to ensure consistent and reproducible deployments.

    tag: "0.1.0"

@phongphongg phongphongg force-pushed the feat/iam branch 12 times, most recently from afac331 to 4c5472e Compare March 15, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant