Add authentication module test coverage

[phongphongg]

Summary

• add JUnit tests for the authentication controller, login filter, and security handlers
• ensure malformed login payloads surface as bad credentials responses
• configure authentication module test tooling for JUnit Platform

Testing

• ./gradlew test --console=plain

---

Codex Task

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/add-automated-tests-for-main-features

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @phongphongg, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the reliability and maintainability of the authentication module by adding extensive JUnit test coverage across its core components. It addresses potential vulnerabilities by ensuring that malformed login requests are properly rejected and also updates the build configuration to leverage the latest JUnit testing framework.

Highlights

• Expanded Test Coverage: Introduced comprehensive JUnit tests for the authentication controller, login filter, and security handlers to ensure robustness.
• Improved Error Handling: Enhanced the JsonLoginAuthenticationFilter to correctly handle malformed JSON login payloads, returning BadCredentialsException.
• JUnit Platform Integration: Configured the authentication module's build to utilize JUnit Platform, modernizing the test execution environment.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a comprehensive suite of JUnit tests for the authentication module, significantly improving test coverage for the controller, login filter, and security handlers. The changes are well-implemented, particularly the handling of malformed login payloads. I have a couple of suggestions to enhance the new tests for greater clarity and robustness.

[gemini-code-assist]

This test is missing some assertions to fully verify the structure of the ApiResponse. For consistency with getCsrfWrapsTokenInApiResponse and to make the test more robust, you should also assert that message and errors are null, and that meta is not null.

        assertTrue(response.success());
        assertEquals("OK", response.code());
        assertNull(response.message());
        assertSame(authentication, response.data());
        assertNull(response.errors());
        assertNotNull(response.meta());

[gemini-code-assist]

This assertion is misleading and should be removed. When attemptAuthentication throws an exception, it doesn't modify the HttpServletResponse. The status code is set later in the filter chain by an exception handler (e.g., an AuthenticationEntryPoint). The MockHttpServletResponse simply retains its default status of 200 (OK), which is not a behavior of the filter being tested.