Added AssertiveComparisonChecker’s suppress_multidrive_messages suppo…#54
Added AssertiveComparisonChecker’s suppress_multidrive_messages suppo…#54xross wants to merge 1 commit into
Conversation
…rt/param to ComparisonChecker
There was a problem hiding this comment.
Pull request overview
Ports the suppress_multidrive_messages parameter from AssertiveComparisonTester to ComparisonTester so that ComparisonTester can also filter out "Internal control pad and plugin driving in opposite directions" lines from the output before comparing against the golden reference.
Changes:
- Adds
suppress_multidrive_messagesconstructor parameter (defaultTrue) and stores it onself._smm. - Updates the
run()loop to skip matching lines before applying user-providedignoreregex patterns. - Updates docstring and
CHANGELOG.rstaccordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/python/Pyxsim/testers.py | New param, attribute, filtering branch and docstring update on ComparisonTester. |
| CHANGELOG.rst | UNRELEASED entry documenting the new param. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ignore=[], | ||
| ordered=True, | ||
| verbosity=0, | ||
| suppress_multidrive_messages=True, |
There was a problem hiding this comment.
Why does it default to True?
How is it enabled/disabled?
There was a problem hiding this comment.
its enabled by default in AssertiveComparisonCheckers so I matched it
Set in object creation.
I think there is an argument to make a single ComparisonChecker with an assertive param.
…rt/param to ComparisonChecker